From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-pm@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org, NeilBrown <neil@brown.name>
Subject: Re: [PATCH] twl4030_charger: fix another compile error
Date: Fri, 4 Sep 2015 16:55:29 -0700 [thread overview]
Message-ID: <20150904235528.GC4215@atomide.com> (raw)
In-Reply-To: <1441409554-518-1-git-send-email-notasas@gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [150904 16:36]:
> When CONFIG_CHARGER_TWL4030=y and CONFIG_TWL4030_MADC=m we get a
> compile error:
>
> drivers/built-in.o: In function `twl4030_charger_update_current':
> twl4030_charger.c:(.text+0x504681): undefined reference to
> `twl4030_get_madc_conversion'
>
> Use IS_REACHABLE to fix it.
>
> Cc: NeilBrown <neil@brown.name>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Looks OK to me:
Acked-by: Tony Lindgren <tony#atomide.com>
> ---
> drivers/power/twl4030_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
> index f4f2c1f..5bcc76f 100644
> --- a/drivers/power/twl4030_charger.c
> +++ b/drivers/power/twl4030_charger.c
> @@ -91,7 +91,7 @@
> #define TWL4030_MSTATEC_COMPLETE1 0x0b
> #define TWL4030_MSTATEC_COMPLETE4 0x0e
>
> -#if IS_ENABLED(CONFIG_TWL4030_MADC)
> +#if IS_REACHABLE(CONFIG_TWL4030_MADC)
> /*
> * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
> * then AC is available.
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-09-04 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 23:32 [PATCH] twl4030_charger: fix another compile error Grazvydas Ignotas
2015-09-04 23:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904235528.GC4215@atomide.com \
--to=tony@atomide.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil@brown.name \
--cc=notasas@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).