linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
@ 2015-09-08 17:13 Bartlomiej Zolnierkiewicz
  2015-09-09  1:13 ` Rafael J. Wysocki
  2015-09-09  2:27 ` Viresh Kumar
  0 siblings, 2 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2015-09-08 17:13 UTC (permalink / raw)
  To: Viresh Kumar, Rafael J. Wysocki, Stephen Warren, Thierry Reding,
	Alexandre Courbot
  Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-pm-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ

CONFIG_PM ifdefs are superfluous and can be removed.

Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/cpufreq/tegra20-cpufreq.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
index 8084c7f..2bd6284 100644
--- a/drivers/cpufreq/tegra20-cpufreq.c
+++ b/drivers/cpufreq/tegra20-cpufreq.c
@@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = {
 	.exit			= tegra_cpu_exit,
 	.name			= "tegra",
 	.attr			= cpufreq_generic_attr,
-#ifdef CONFIG_PM
 	.suspend		= cpufreq_generic_suspend,
-#endif
 };
 
 static int __init tegra_cpufreq_init(void)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
  2015-09-08 17:13 [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs Bartlomiej Zolnierkiewicz
@ 2015-09-09  1:13 ` Rafael J. Wysocki
       [not found]   ` <9512123.FfVbKErfZO-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
  2015-09-09  2:27 ` Viresh Kumar
  1 sibling, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-09-09  1:13 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: Viresh Kumar, Stephen Warren, Thierry Reding, Alexandre Courbot,
	linux-tegra, linux-pm, linux-kernel

On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote:
> CONFIG_PM ifdefs are superfluous and can be removed.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

What tree does this apply to?

> ---
>  drivers/cpufreq/tegra20-cpufreq.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> index 8084c7f..2bd6284 100644
> --- a/drivers/cpufreq/tegra20-cpufreq.c
> +++ b/drivers/cpufreq/tegra20-cpufreq.c
> @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = {
>  	.exit			= tegra_cpu_exit,
>  	.name			= "tegra",
>  	.attr			= cpufreq_generic_attr,
> -#ifdef CONFIG_PM
>  	.suspend		= cpufreq_generic_suspend,
> -#endif
>  };
>  
>  static int __init tegra_cpufreq_init(void)
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
  2015-09-08 17:13 [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs Bartlomiej Zolnierkiewicz
  2015-09-09  1:13 ` Rafael J. Wysocki
@ 2015-09-09  2:27 ` Viresh Kumar
  1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2015-09-09  2:27 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: Rafael J. Wysocki, Stephen Warren, Thierry Reding,
	Alexandre Courbot, linux-tegra, linux-pm, linux-kernel

On 08-09-15, 19:13, Bartlomiej Zolnierkiewicz wrote:
> CONFIG_PM ifdefs are superfluous and can be removed.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/cpufreq/tegra20-cpufreq.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> index 8084c7f..2bd6284 100644
> --- a/drivers/cpufreq/tegra20-cpufreq.c
> +++ b/drivers/cpufreq/tegra20-cpufreq.c
> @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = {
>  	.exit			= tegra_cpu_exit,
>  	.name			= "tegra",
>  	.attr			= cpufreq_generic_attr,
> -#ifdef CONFIG_PM
>  	.suspend		= cpufreq_generic_suspend,
> -#endif
>  };
>  
>  static int __init tegra_cpufreq_init(void)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
       [not found]   ` <9512123.FfVbKErfZO-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
@ 2015-09-09 10:36     ` Bartlomiej Zolnierkiewicz
  2015-09-09 20:14       ` Rafael J. Wysocki
  0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2015-09-09 10:36 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Viresh Kumar, Stephen Warren, Thierry Reding, Alexandre Courbot,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-pm-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA


Hi,

On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote:
> On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote:
> > CONFIG_PM ifdefs are superfluous and can be removed.
> > 
> > Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> > Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 
> What tree does this apply to?

It applies fine to both next (next-20150909 branch) and current Linus'
tree (top commit is a794b4f).

> > ---
> >  drivers/cpufreq/tegra20-cpufreq.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> > index 8084c7f..2bd6284 100644
> > --- a/drivers/cpufreq/tegra20-cpufreq.c
> > +++ b/drivers/cpufreq/tegra20-cpufreq.c
> > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = {
> >  	.exit			= tegra_cpu_exit,
> >  	.name			= "tegra",
> >  	.attr			= cpufreq_generic_attr,
> > -#ifdef CONFIG_PM
> >  	.suspend		= cpufreq_generic_suspend,
> > -#endif
> >  };
> >  
> >  static int __init tegra_cpufreq_init(void)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
  2015-09-09 10:36     ` Bartlomiej Zolnierkiewicz
@ 2015-09-09 20:14       ` Rafael J. Wysocki
  2015-10-05 20:46         ` Rafael J. Wysocki
  0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-09-09 20:14 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: Viresh Kumar, Stephen Warren, Thierry Reding, Alexandre Courbot,
	linux-tegra, linux-pm, linux-kernel

On Wednesday, September 09, 2015 12:36:39 PM Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote:
> > On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote:
> > > CONFIG_PM ifdefs are superfluous and can be removed.
> > > 
> > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Alexandre Courbot <gnurou@gmail.com>
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > 
> > What tree does this apply to?
> 
> It applies fine to both next (next-20150909 branch) and current Linus'
> tree (top commit is a794b4f).

OK

My cpufreq branch has not acquired tegra20-cpufreq.c yet, so I'll apply this
one when -rc1 is out.  Or please ask whoever merged that driver to apply it
earlier if you want to.


> > > ---
> > >  drivers/cpufreq/tegra20-cpufreq.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> > > index 8084c7f..2bd6284 100644
> > > --- a/drivers/cpufreq/tegra20-cpufreq.c
> > > +++ b/drivers/cpufreq/tegra20-cpufreq.c
> > > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = {
> > >  	.exit			= tegra_cpu_exit,
> > >  	.name			= "tegra",
> > >  	.attr			= cpufreq_generic_attr,
> > > -#ifdef CONFIG_PM
> > >  	.suspend		= cpufreq_generic_suspend,
> > > -#endif
> > >  };
> > >  
> > >  static int __init tegra_cpufreq_init(void)
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs
  2015-09-09 20:14       ` Rafael J. Wysocki
@ 2015-10-05 20:46         ` Rafael J. Wysocki
  0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-10-05 20:46 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: Viresh Kumar, Stephen Warren, Thierry Reding, Alexandre Courbot,
	linux-tegra, linux-pm, linux-kernel

On Wednesday, September 09, 2015 10:14:50 PM Rafael J. Wysocki wrote:
> On Wednesday, September 09, 2015 12:36:39 PM Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote:
> > > On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote:
> > > > CONFIG_PM ifdefs are superfluous and can be removed.
> > > > 
> > > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > Cc: Alexandre Courbot <gnurou@gmail.com>
> > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > 
> > > What tree does this apply to?
> > 
> > It applies fine to both next (next-20150909 branch) and current Linus'
> > tree (top commit is a794b4f).
> 
> OK
> 
> My cpufreq branch has not acquired tegra20-cpufreq.c yet, so I'll apply this
> one when -rc1 is out.  Or please ask whoever merged that driver to apply it
> earlier if you want to.

Applied now, thanks!

Rafael

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-10-05 20:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08 17:13 [PATCH] cpufreq: tegra20: remove superfluous CONFIG_PM ifdefs Bartlomiej Zolnierkiewicz
2015-09-09  1:13 ` Rafael J. Wysocki
     [not found]   ` <9512123.FfVbKErfZO-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-09-09 10:36     ` Bartlomiej Zolnierkiewicz
2015-09-09 20:14       ` Rafael J. Wysocki
2015-10-05 20:46         ` Rafael J. Wysocki
2015-09-09  2:27 ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).