Re: [PATCH v2 10/13] power: bq24257: Add various device-specific sysfs properties

Andreas Dannenberg
2015-09-10T18:54:03Z

On Thu, Sep 10, 2015 at 05:13:32PM +0300, Laurentiu Palcu wrote:
> On Tue, Sep 08, 2015 at 07:12:34PM -0500, Andreas Dannenberg wrote:
> > This patch adds support to enable/disable some device specific features
> > through device properties at boot time or sysfs properties at runtime
> > depending on whether they should be accessible during runtime or not.
> > The use of those features is be optional however they might be helpful
> > in certain scenarios:
> >
> > * High-impedance mode enable/disable (through sysfs r/w)
> > * Sysoff enable/disable (through sysfs r/w)
> > * 2X Timer enable/disable (through "ti,safety-timer-2x-enable" dev
> > property)
> >
> > If not explicitly modified those settings are left at their device-
> > specific power-on defaults. Refer to the respectice device datasheets
> > for more information:
> >
> > http://www.ti.com/product/bq24250
> > http://www.ti.com/product/bq24251
> > http://www.ti.com/product/bq24257
> >
> > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
>
> I'm OK with adding these properties, but I'll wait for your explanation
> on the mutex patch since I really don't think you need it, except for
> protecting chip state data.

Yes as per the other thread we don't need additional mutex protection
after all.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc

>
> laurentiu