From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Kristen Carlson Accardi <kristen@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] cpufreq: pass policy to ->get() driver callback
Date: Tue, 15 Sep 2015 13:28:49 +0530 [thread overview]
Message-ID: <20150915075849.GC6350@linux> (raw)
In-Reply-To: <20150915073921.GA6350@linux>
On 15-09-15, 13:09, Viresh Kumar wrote:
> I would have sent a patch for this, but I thought you would like to
> edit the original patch itself to not break git bisect.
But in case you are applying it separately, here is the fix.
-------------------------8<-------------------------
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Tue, 15 Sep 2015 13:09:54 +0530
Subject: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function
anymore
Its used outside of the core file and is exported as well. Drop the
'static' keyword from its declaration and fix below build error:
linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of
'cpufreq_cpu_get_raw' follows non-static declaration
Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a8252bb0f80c..ef5ed9470de9 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -238,7 +238,7 @@ int cpufreq_generic_init(struct cpufreq_policy *policy,
}
EXPORT_SYMBOL_GPL(cpufreq_generic_init);
-static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
+struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
{
struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
next prev parent reply other threads:[~2015-09-15 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 10:44 [PATCH] cpufreq: pass policy to ->get() driver callback Viresh Kumar
2015-09-03 4:45 ` Viresh Kumar
2015-09-04 14:50 ` Rafael J. Wysocki
2015-09-10 1:41 ` Rafael J. Wysocki
2015-09-10 1:22 ` Viresh Kumar
2015-09-10 21:36 ` Rafael J. Wysocki
2015-09-11 16:18 ` Viresh Kumar
2015-09-15 7:39 ` Viresh Kumar
2015-09-15 7:58 ` Viresh Kumar [this message]
2015-09-16 1:30 ` Rafael J. Wysocki
2015-09-10 21:40 ` Rafael J. Wysocki
2015-09-10 21:59 ` Rafael J. Wysocki
2015-09-15 7:54 ` Viresh Kumar
2015-09-16 1:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915075849.GC6350@linux \
--to=viresh.kumar@linaro.org \
--cc=kristen@linux.intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).