From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Dan Murphy <dmurphy@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS
Date: Mon, 21 Sep 2015 10:33:45 +0200 [thread overview]
Message-ID: <20150921083345.GE20113@pali> (raw)
In-Reply-To: <1442265973-32261-2-git-send-email-afd@ti.com>
On Monday 14 September 2015 16:26:07 Andrew F. Davis wrote:
> The MODULE_DEVICE_TABLE macro automatically adds all needed
> i2c MODULE_ALIASes so remove the extra MODULE_ALIAS.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> drivers/power/bq27x00_battery.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 8287261f..d0b2f3b 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -1120,10 +1120,6 @@ module_exit(bq27x00_battery_exit);
> MODULE_ALIAS("platform:bq27000-battery");
> #endif
>
> -#ifdef CONFIG_BATTERY_BQ27X00_I2C
> -MODULE_ALIAS("i2c:bq27000-battery");
> -#endif
> -
> MODULE_AUTHOR("Rodolfo Giometti <giometti@linux.it>");
> MODULE_DESCRIPTION("BQ27x00 battery monitor driver");
> MODULE_LICENSE("GPL");
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2015-09-21 8:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 21:26 [PATCH v4 0/7] Add support for additional bq27xxx devices Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Andrew F. Davis
2015-09-21 8:33 ` Pali Rohár [this message]
2015-09-22 15:18 ` Sebastian Reichel
2015-09-14 21:26 ` [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-09-15 8:32 ` Laurentiu Palcu
2015-09-15 16:53 ` Andrew F. Davis
2015-09-22 16:10 ` Sebastian Reichel
2015-09-14 21:26 ` [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device Andrew F. Davis
2015-09-21 8:41 ` Pali Rohár
2015-09-21 18:40 ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-09-21 8:36 ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-09-21 8:46 ` Pali Rohár
2015-09-21 19:02 ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-09-21 8:35 ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support Andrew F. Davis
2015-09-15 18:47 ` Andreas Dannenberg
2015-09-15 20:53 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921083345.GE20113@pali \
--to=pali.rohar@gmail.com \
--cc=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dmurphy@ti.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).