From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Palcu Subject: Re: [PATCH v6 08/14] power: bq24257: Use managed power supply register Date: Fri, 25 Sep 2015 16:43:16 +0300 Message-ID: <20150925134316.GE15509@lpalcu-desk> References: <1443151618-29742-1-git-send-email-dannenberg@ti.com> <1443151618-29742-9-git-send-email-dannenberg@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga14.intel.com ([192.55.52.115]:44721 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756117AbbIYNnf (ORCPT ); Fri, 25 Sep 2015 09:43:35 -0400 Content-Disposition: inline In-Reply-To: <1443151618-29742-9-git-send-email-dannenberg@ti.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Andreas Dannenberg Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Krzysztof Kozlowski , Ramakrishna Pallala , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-api@vger.kernel.org On Thu, Sep 24, 2015 at 10:26:52PM -0500, Andreas Dannenberg wrote: [...] > - bq->charger = power_supply_register(bq->dev, &bq24257_power_supply_desc, > - &psy_cfg); > + bq->charger = devm_power_supply_register(bq->dev, > + &bq24257_power_supply_desc, > + &psy_cfg); > + > if (IS_ERR(bq->charger)) > return PTR_ERR(bq->charger); This is unrelated but, since we're here and if you ever send another version for these patches, we could change these two lines (and the 'return 0' that follows) to just: return PTR_ERR_OR_ZERO(bq->charger); laurentiu