* [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health()
@ 2015-09-28 9:16 Dan Carpenter
2015-09-28 15:08 ` Andrew F. Davis
2015-09-28 16:33 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-09-28 9:16 UTC (permalink / raw)
To: Pali Rohár, Andrew F. Davis
Cc: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm, kernel-janitors
We need flags to be signed for the error handling to work.
Fixes: 74aab849f342 ('power: bq27xxx_battery: Cleanup health checking')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index 473aa2f..994c78d 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
*/
static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
{
- u16 flags;
+ int flags;
flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
if (flags < 0) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health()
2015-09-28 9:16 [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health() Dan Carpenter
@ 2015-09-28 15:08 ` Andrew F. Davis
2015-09-28 16:33 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew F. Davis @ 2015-09-28 15:08 UTC (permalink / raw)
To: Dan Carpenter, Pali Rohár
Cc: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm, kernel-janitors
On 09/28/2015 04:16 AM, Dan Carpenter wrote:
> We need flags to be signed for the error handling to work.
>
> Fixes: 74aab849f342 ('power: bq27xxx_battery: Cleanup health checking')
This bug looks to have been added back in c91d36ea8116, either way the
fix itself is correct so,
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Andrew F. Davis <afd@ti.com>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 473aa2f..994c78d 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
> */
> static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
> {
> - u16 flags;
> + int flags;
>
> flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
> if (flags < 0) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health()
2015-09-28 9:16 [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health() Dan Carpenter
2015-09-28 15:08 ` Andrew F. Davis
@ 2015-09-28 16:33 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2015-09-28 16:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Pali Rohár, Andrew F. Davis, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
Hi,
On Mon, Sep 28, 2015 at 12:16:53PM +0300, Dan Carpenter wrote:
> We need flags to be signed for the error handling to work.
>
> Fixes: 74aab849f342 ('power: bq27xxx_battery: Cleanup health checking')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Andrzej Hajda was slightly fast than you, so I merged his
patch instead. I merged some of your patch description into his
patch, though.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-28 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28 9:16 [patch] power: bq27xxx_battery: signedness bug in bq27xxx_battery_read_health() Dan Carpenter
2015-09-28 15:08 ` Andrew F. Davis
2015-09-28 16:33 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).