From: Viresh Kumar <viresh.kumar@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nishanth Menon <nm@ti.com>, Len Brown <len.brown@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Dmitry Torokhov <dtor@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / OPP: fix debugfs files for 64-bit
Date: Wed, 7 Oct 2015 22:06:59 +0530 [thread overview]
Message-ID: <20151007163659.GB4557@linux> (raw)
In-Reply-To: <20151007163309.GM21513@n2100.arm.linux.org.uk>
On 07-10-15, 17:33, Russell King - ARM Linux wrote:
> Don't you even think about doing that - that's totally broken no matter
> what, and this is a good example of why casts are Bad.
>
> debugfs_create_u64() will create a debugfs object that will want to
> access a 64-bit value, but the value pointed to is only 32-bit. The
> net result is that the debugfs file ends up reading or writing the
> neigbouring 32-bits, which may potentially be unaligned.
Yeah, that's what I was also saying. Its broken.
> The variable pointed to for debugfs_create_u64() must be a 64-bit
> value. No casts allowed.
>
> An alternative would be to have debugfs_create_ulong()
And that's what I suggested.
--
viresh
prev parent reply other threads:[~2015-10-07 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 7:35 [PATCH] PM / OPP: fix debugfs files for 64-bit Arnd Bergmann
2015-10-07 10:59 ` Viresh Kumar
2015-10-07 11:03 ` Viresh Kumar
2015-10-07 11:07 ` Greg Kroah-Hartman
2015-10-07 11:21 ` Viresh Kumar
2015-10-07 12:57 ` Greg Kroah-Hartman
2015-10-07 13:03 ` Viresh Kumar
2015-10-07 17:19 ` Greg Kroah-Hartman
2015-10-07 17:27 ` Viresh Kumar
2015-10-07 17:39 ` Greg Kroah-Hartman
2015-10-07 18:00 ` Viresh Kumar
2015-10-07 19:12 ` Arnd Bergmann
2015-10-08 7:48 ` Viresh Kumar
2015-10-08 14:25 ` Alan Stern
2015-10-19 15:40 ` Michael Turquette
2015-10-19 15:53 ` Russell King - ARM Linux
2015-10-20 10:22 ` Michael Turquette
2015-10-07 16:33 ` Russell King - ARM Linux
2015-10-07 16:36 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007163659.GB4557@linux \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).