From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()
Date: Thu, 15 Oct 2015 09:42:47 +0200 [thread overview]
Message-ID: <20151015094247.44f29da9@free-electrons.com> (raw)
In-Reply-To: <20151015073544.GE19018@linux>
Viresh, Rafael,
On Thu, 15 Oct 2015 13:05:44 +0530, Viresh Kumar wrote:
> On 14-10-15, 17:52, Thomas Petazzoni wrote:
> > ret = of_init_opp_table(cpu_dev);
> > if (ret) {
> > - pr_err("%s: couldn't find opp table for cpu:%d, %d\n",
> > - __func__, cpu, ret);
> > -
>
> It should have be modified to pr_debug() at least.
Would be fine as well, but then maybe with a rewording:
pr_debug("%s: no static opp table found for cpu %d, assuming one will be added at runtime (%d)\n",
__func__, cpu, ret);
Do you want me to resend a new version? Or a follow-up patch based on
the latest tree from Rafael now that he has applied the previous version?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-15 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 15:52 [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table() Thomas Petazzoni
2015-10-14 21:28 ` Rafael J. Wysocki
2015-10-14 21:10 ` Thomas Petazzoni
2015-10-14 21:44 ` Rafael J. Wysocki
2015-10-14 21:29 ` Thomas Petazzoni
2015-10-14 21:59 ` Rafael J. Wysocki
2015-10-14 21:31 ` Thomas Petazzoni
2015-10-15 7:35 ` Viresh Kumar
2015-10-15 7:42 ` Thomas Petazzoni [this message]
2015-10-15 14:37 ` Viresh Kumar
2015-10-15 21:26 ` Rafael J. Wysocki
2015-10-16 5:39 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015094247.44f29da9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@free-electrons.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tawfik@marvell.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).