From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Dmitry Torokhov <dtor@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt
Date: Fri, 16 Oct 2015 11:07:13 +0530 [thread overview]
Message-ID: <20151016053713.GO19018@linux> (raw)
In-Reply-To: <20151015190421.GK4558@codeaurora.org>
On 15-10-15, 12:04, Stephen Boyd wrote:
> On 10/15, Viresh Kumar wrote:
> > With debug options on, it is difficult to locate OPP core's debug
> > prints. Fix this by prefixing OPP debug prints with KBUILD_MODNAME.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Why not use dynamic debug's m flag to turn on KBUILD_MODNAME when
> debugging?
>
> >From Documentation/dynamic-debug-howto.txt
>
> m Include module name in the printed message
It wasn't just about debug messages but pr_info and pr_err as well.
And so I defined pr_fmt instead.
--
viresh
next prev parent reply other threads:[~2015-10-16 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 16:12 [PATCH V2 0/4] OPP: Some cleanups Viresh Kumar
2015-10-15 16:12 ` [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Viresh Kumar
2015-10-15 19:04 ` Stephen Boyd
2015-10-16 5:37 ` Viresh Kumar [this message]
2015-10-16 19:20 ` Stephen Boyd
2015-10-17 4:15 ` [PATCH V3 1/4] PM / OPP: Improve " Viresh Kumar
2015-10-28 18:49 ` Stephen Boyd
2015-10-15 16:12 ` [PATCH V2 2/4] PM / OPP: Rename routines specific to old bindings with _v1 Viresh Kumar
2015-10-28 18:48 ` Stephen Boyd
2015-10-15 16:12 ` [PATCH V2 3/4] PM / OPP: Parse all power-supply related bindings together Viresh Kumar
2015-10-28 18:48 ` Stephen Boyd
2015-10-15 16:12 ` [PATCH V2 4/4] PM / OPP: Create separate structure for regulator/supplies Viresh Kumar
2015-10-28 8:37 ` Viresh Kumar
2015-10-28 8:25 ` [PATCH V2 0/4] OPP: Some cleanups Rafael J. Wysocki
2015-10-28 8:40 ` Viresh Kumar
2015-10-28 18:48 ` Stephen Boyd
2015-11-05 22:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016053713.GO19018@linux \
--to=viresh.kumar@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).