From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt Date: Fri, 16 Oct 2015 12:20:31 -0700 Message-ID: <20151016192031.GB16437@codeaurora.org> References: <20151015190421.GK4558@codeaurora.org> <20151016053713.GO19018@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151016053713.GO19018@linux> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, Bartlomiej Zolnierkiewicz , Dan Carpenter , Dmitry Torokhov , Greg Kroah-Hartman , Len Brown , open list , Pavel Machek List-Id: linux-pm@vger.kernel.org On 10/16, Viresh Kumar wrote: > On 15-10-15, 12:04, Stephen Boyd wrote: > > On 10/15, Viresh Kumar wrote: > > > With debug options on, it is difficult to locate OPP core's debug > > > prints. Fix this by prefixing OPP debug prints with KBUILD_MODNAME. > > > > > > Signed-off-by: Viresh Kumar > > > > Why not use dynamic debug's m flag to turn on KBUILD_MODNAME when > > debugging? > > > > >From Documentation/dynamic-debug-howto.txt > > > > m Include module name in the printed message > > It wasn't just about debug messages but pr_info and pr_err as well. > And so I defined pr_fmt instead. > Ok, well the commit text exclusively mentions debug, leading me to believe this is all about making the debug prints (i.e. pr_debug) have KBUILD_MODNAME. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project