From: Viresh Kumar <viresh.kumar@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linaro-kernel@lists.linaro.org,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, arnd@arndb.de,
sboyd@codeaurora.org, linux-pm@vger.kernel.org,
linux@arm.linux.org.uk, stern@rowland.harvard.edu
Subject: Re: [PATCH V3] debugfs: Add debugfs_create_ulong()
Date: Sun, 18 Oct 2015 22:14:09 +0530 [thread overview]
Message-ID: <20151018164409.GE19018@linux> (raw)
In-Reply-To: <20151018162140.GA30196@kroah.com>
On 18-10-15, 09:21, Greg Kroah-Hartman wrote:
> On Sun, Oct 18, 2015 at 02:45:27PM +0530, Viresh Kumar wrote:
> > Add debugfs_create_ulong() for the users of type 'unsigned long'. These
> > will be 32 bits long on a 32 bit machine and 64 bits long on a 64 bit
> > machine.
>
> Do you really need a debugfs_create_xlong()? You don't mention it here
> in your changelog comment yet the patch contains it. I'd hold off for
> it for now as I doubt anyone needs it...
At least my use case doesn't need it, but I thought it will be better
to implement the ulong series in the same way other interfaces are
implemented.
I can drop that part if you want.
--
viresh
next prev parent reply other threads:[~2015-10-18 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 9:15 [PATCH V3] debugfs: Add debugfs_create_ulong() Viresh Kumar
2015-10-18 16:21 ` Greg Kroah-Hartman
2015-10-18 16:44 ` Viresh Kumar [this message]
2015-10-18 17:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018164409.GE19018@linux \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).