From: Pavel Machek <pavel@ucw.cz>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>,
Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Subject: Re: [PATCH 2/2] PM / Domains: Merge measurements for PM QoS device latencies
Date: Wed, 21 Oct 2015 12:33:11 +0200 [thread overview]
Message-ID: <20151021103311.GA17163@amd> (raw)
In-Reply-To: <1444921339-22614-1-git-send-email-ulf.hansson@linaro.org>
On Thu 2015-10-15 17:02:19, Ulf Hansson wrote:
> Measure latency does by itself contribute to an increased latency, thus we
> should avoid it when it isn't needed.
>
> By merging the latency measurements for the ->save_state() and the
> ->stop() callbacks, we get one measurement instead of two and we get one
> value to store instead of two. Let's also apply the likewise change for
> the ->start() and ->restore_state() callbacks.
I guess we should simply delete the latency measurement code at this
point, and let interested parties patch their kernels to do the
measurements.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-10-21 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 15:02 [PATCH 2/2] PM / Domains: Merge measurements for PM QoS device latencies Ulf Hansson
2015-10-15 21:18 ` Lina Iyer
2015-10-21 10:33 ` Pavel Machek [this message]
2015-10-22 13:52 ` Ulf Hansson
2015-10-23 18:49 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021103311.GA17163@amd \
--to=pavel@ucw.cz \
--cc=geert+renesas@glider.be \
--cc=k.kozlowski.k@gmail.com \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).