* [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
@ 2015-10-22 19:52 Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
0 siblings, 2 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-10-22 19:52 UTC (permalink / raw)
To: Sudeep Holla
Cc: Rafael J. Wysocki, Viresh Kumar, linux-arm-kernel, linux-pm,
kernel-janitors
The "domain" variable needs to be signed for the error handling to work.
Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16f..de5e89b 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
- u8 domain = topology_physical_package_id(cpu_dev->id);
+ int domain = topology_physical_package_id(cpu_dev->id);
if (domain < 0)
return ERR_PTR(-EINVAL);
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
@ 2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
1 sibling, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-10-23 1:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Holla, Rafael J. Wysocki, linux-arm-kernel, linux-pm,
kernel-janitors
On 22-10-15, 22:52, Dan Carpenter wrote:
> The "domain" variable needs to be signed for the error handling to work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index 2c3b16f..de5e89b 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
>
> static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
> {
> - u8 domain = topology_physical_package_id(cpu_dev->id);
> + int domain = topology_physical_package_id(cpu_dev->id);
>
> if (domain < 0)
> return ERR_PTR(-EINVAL);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
@ 2015-10-23 10:16 ` Sudeep Holla
2015-11-26 14:07 ` Sudeep Holla
1 sibling, 1 reply; 8+ messages in thread
From: Sudeep Holla @ 2015-10-23 10:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Holla, Viresh Kumar, kernel-janitors, Rafael J. Wysocki,
linux-arm-kernel, linux-pm
On 22/10/15 20:52, Dan Carpenter wrote:
> The "domain" variable needs to be signed for the error handling to
> work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface
> driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Thanks for the fix
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-23 10:16 ` Sudeep Holla
@ 2015-11-26 14:07 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2015-11-26 14:07 UTC (permalink / raw)
To: Dan Carpenter, Rafael J. Wysocki
Cc: Sudeep Holla, Viresh Kumar, kernel-janitors, linux-arm-kernel,
Linux PM list
Hi Rafael,
On Fri, Oct 23, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>
> On 22/10/15 20:52, Dan Carpenter wrote:
>>
>> The "domain" variable needs to be signed for the error handling to
>> work.
>>
>> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface
>> driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Thanks for the fix
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
Can you pick this up for your next -rc fixes ?
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
@ 2015-12-15 11:16 Sudeep Holla
2015-12-23 11:20 ` Sudeep Holla
0 siblings, 1 reply; 8+ messages in thread
From: Sudeep Holla @ 2015-12-15 11:16 UTC (permalink / raw)
To: linux-pm, linux-kernel, Rafael J. Wysocki; +Cc: Viresh Kumar, Dan Carpenter
From: Dan Carpenter <dan.carpenter@oracle.com>
The "domain" variable needs to be signed for the error handling to work.
Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/cpufreq/scpi-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi Rafael,
This patch seem to have slipped through the cracks somehow. I don't see
in patchwork too. So I am resending so that you can pick for your next
rc fix if you plan to send one else for -next
Regards,
Sudeep
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16fd3a01..de5e89b2eaaa 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
- u8 domain = topology_physical_package_id(cpu_dev->id);
+ int domain = topology_physical_package_id(cpu_dev->id);
if (domain < 0)
return ERR_PTR(-EINVAL);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-12-15 11:16 [PATCH] " Sudeep Holla
@ 2015-12-23 11:20 ` Sudeep Holla
2015-12-24 1:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Sudeep Holla @ 2015-12-23 11:20 UTC (permalink / raw)
To: Linux PM list, open list, Rafael J. Wysocki; +Cc: Viresh Kumar, Dan Carpenter
Hi Rafael,
On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> The "domain" variable needs to be signed for the error handling to work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/cpufreq/scpi-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Rafael,
>
> This patch seem to have slipped through the cracks somehow. I don't see
> in patchwork too. So I am resending so that you can pick for your next
> rc fix if you plan to send one else for -next
>
This got missed again, can you please ensure to pull this for your next -rc.
If you have none planned, please pull this for-next.
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-12-23 11:20 ` Sudeep Holla
@ 2015-12-24 1:45 ` Rafael J. Wysocki
2015-12-24 9:53 ` Sudeep Holla
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2015-12-24 1:45 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Linux PM list, open list, Viresh Kumar, Dan Carpenter
On Wednesday, December 23, 2015 11:20:04 AM Sudeep Holla wrote:
> Hi Rafael,
>
> On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > The "domain" variable needs to be signed for the error handling to work.
> >
> > Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/cpufreq/scpi-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi Rafael,
> >
> > This patch seem to have slipped through the cracks somehow. I don't see
> > in patchwork too. So I am resending so that you can pick for your next
> > rc fix if you plan to send one else for -next
> >
>
> This got missed again, can you please ensure to pull this for your next -rc.
> If you have none planned, please pull this for-next.
Applied now, thanks!
I'm going to push it for -rc7.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-12-24 1:45 ` Rafael J. Wysocki
@ 2015-12-24 9:53 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2015-12-24 9:53 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Sudeep Holla, Linux PM list, open list, Viresh Kumar,
Dan Carpenter
On 24/12/15 01:45, Rafael J. Wysocki wrote:
> On Wednesday, December 23, 2015 11:20:04 AM Sudeep Holla wrote:
>> Hi Rafael,
>>
>> On Tue, Dec 15, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>> From: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> The "domain" variable needs to be signed for the error handling to work.
>>>
>>> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>>> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>>> ---
>>> drivers/cpufreq/scpi-cpufreq.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Hi Rafael,
>>>
>>> This patch seem to have slipped through the cracks somehow. I don't see
>>> in patchwork too. So I am resending so that you can pick for your next
>>> rc fix if you plan to send one else for -next
>>>
>>
>> This got missed again, can you please ensure to pull this for your next -rc.
>> If you have none planned, please pull this for-next.
>
> Applied now, thanks!
>
> I'm going to push it for -rc7.
>
Thanks, sorry for the nags.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-12-24 9:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
2015-11-26 14:07 ` Sudeep Holla
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 11:16 [PATCH] " Sudeep Holla
2015-12-23 11:20 ` Sudeep Holla
2015-12-24 1:45 ` Rafael J. Wysocki
2015-12-24 9:53 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).