* [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig
@ 2015-11-09 21:23 Andrew F. Davis
2015-11-09 21:32 ` Arnd Bergmann
2015-11-10 3:50 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Andrew F. Davis @ 2015-11-09 21:23 UTC (permalink / raw)
To: Arnd Bergmann, Sebastian Reichel, Pali Rohar, Xiong Zhou,
Dmitry Eremin-Solenikov, David Woodhouse
Cc: linux-pm, linux-i2c, linux-arm-kernel, linux-kernel,
Andrew F. Davis
Check if I2C core has been built as a module when BATTERY_BQ27XXX
is built-in. If so disable I2C functionality.
Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/power/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 237d7aa..2f944d7 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -166,6 +166,7 @@ config BATTERY_BQ27XXX_I2C
bool "BQ27xxx I2C support"
depends on BATTERY_BQ27XXX
depends on I2C
+ depends on !(I2C=m && BATTERY_BQ27XXX=y)
default y
help
Say Y here to enable support for batteries with BQ27xxx (I2C) chips.
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig
2015-11-09 21:23 [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig Andrew F. Davis
@ 2015-11-09 21:32 ` Arnd Bergmann
2015-11-10 3:50 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-11-09 21:32 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Sebastian Reichel, Pali Rohar, Xiong Zhou,
Dmitry Eremin-Solenikov, David Woodhouse, linux-pm, linux-i2c,
linux-arm-kernel, linux-kernel
On Monday 09 November 2015 15:23:03 Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
>
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Thanks for the fix!
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig
2015-11-09 21:23 [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig Andrew F. Davis
2015-11-09 21:32 ` Arnd Bergmann
@ 2015-11-10 3:50 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2015-11-10 3:50 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Arnd Bergmann, Pali Rohar, Xiong Zhou, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-i2c, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
Hi,
On Mon, Nov 09, 2015 at 03:23:03PM -0600, Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
>
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-10 3:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-09 21:23 [PATCH] power: bq27xxx_battery: Add I2C module check dependency in Kconfig Andrew F. Davis
2015-11-09 21:32 ` Arnd Bergmann
2015-11-10 3:50 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).