From: Viresh Kumar <viresh.kumar@linaro.org>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: sudeep.holla@arm.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] cpufreq: scpi: Add dependency on SCPI clk driver
Date: Wed, 18 Nov 2015 10:49:53 +0530 [thread overview]
Message-ID: <20151118051953.GB7336@ubuntu> (raw)
In-Reply-To: <1447784059-22769-1-git-send-email-punit.agrawal@arm.com>
On 17-11-15, 18:14, Punit Agrawal wrote:
> The SCPI clk driver registers the virtual cpufreq device that kicks off
> initialisation of the SCPI cpufreq driver. Make the dependendency
> explicit in Kconfig.
That's not a dependency. Any other part of the kernel can add this
*virtual* cpufreq device to get it going.
But, we do have dependency the other way round. clk_get() will fail
for the cpufreq driver if SCPI-clk driver is missing and perhaps
that's what you need to mention in the changelog.
> Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1582c1c..dadfdd4 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
>
> config ARM_SCPI_CPUFREQ
> tristate "SCPI based CPUfreq driver"
> - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
> + depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
This looks fine.
--
viresh
next prev parent reply other threads:[~2015-11-18 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 18:14 [PATCH] cpufreq: scpi: Add dependency on SCPI clk driver Punit Agrawal
2015-11-18 5:19 ` Viresh Kumar [this message]
2015-11-18 13:06 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118051953.GB7336@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox