Re: [PATCH] pcc-cpufreq driver update default value of cpuinfo_transition_latency

[Viresh Kumar <viresh.kumar@linaro.org>]

On 19-11-15, 10:29, Jacob Tanenbaum wrote:
> The cpufreq documentation specifies
> 
> policy->cpuinfo.transition_latency   the time it takes on this CPU to
>                                 switch between two frequencies in
>                                 nanoseconds (if appropriate, else
>                                 specify CPUFREQ_ETERNAL)
> 
> currently pcc-cpufreq does not expose the value and sets it to zero. I
> changed the pcc-cpufreq driver and it's documentation to conform to the
> default value specified in Documentation/cpu-freq/cpu-drivers.txt
> 
> Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
> ---
>  Documentation/cpu-freq/pcc-cpufreq.txt | 4 ++--
>  drivers/cpufreq/pcc-cpufreq.c          | 2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/cpu-freq/pcc-cpufreq.txt b/Documentation/cpu-freq/pcc-cpufreq.txt
> index 9e3c3b3..0a94224 100644
> --- a/Documentation/cpu-freq/pcc-cpufreq.txt
> +++ b/Documentation/cpu-freq/pcc-cpufreq.txt
> @@ -159,8 +159,8 @@ to be strictly associated with a P-state.
>  
>  2.2 cpuinfo_transition_latency:
>  -------------------------------
> -The cpuinfo_transition_latency field is 0. The PCC specification does
> -not include a field to expose this value currently.
> +The cpuinfo_transition_latency field is CPUFREQ_ETERNAL. The PCC specification
> +does not include a field to expose this value currently.
>  
>  2.3 cpuinfo_cur_freq:
>  ---------------------
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 2a0d589..808a320 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -555,6 +555,8 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy)
>  	policy->min = policy->cpuinfo.min_freq =
>  		ioread32(&pcch_hdr->minimum_frequency) * 1000;
>  
> +	policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;
> +
>  	pr_debug("init: policy->max is %d, policy->min is %d\n",
>  		policy->max, policy->min);
>  out:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh