From: Sebastian Reichel <sre@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Gražvydas Ignotas" <notasas@gmail.com>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Andreas Kemnade" <andreas@kemnade.info>,
linux-pm@vger.kernel.org, gta04-owner@goldelico.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fixes for twl4030 charger
Date: Sat, 5 Dec 2015 00:54:42 +0100 [thread overview]
Message-ID: <20151204235442.GA22936@earth> (raw)
In-Reply-To: <cover.1446463652.git.hns@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hi Nikolaus,
On Mon, Nov 02, 2015 at 12:27:33PM +0100, H. Nikolaus Schaller wrote:
> Changes V2:
> * worked in comments by Nishanth Menon <nm@ti.com>
> * added another patch which solves a probing/boot stall problem (irq allocation vs. -EPROBE_DEFER)
>
> V1:
> 4.3-rc1 introduced a new charger driver for the twl4030.
>
> While making it operable and testing on GTA04 and OpenPandora
> we have found some issues.
>
>
> H. Nikolaus Schaller (3):
> drivers:power:twl4030-charger: fix problem with EPROBE_DEFER
> drivers:power:twl4030-charger: don't return after allocating irq
> drivers:power:twl4030-charger: don't check if battery is present
PATCH 1 and 2 should be rebased to my current next branch.
They definetly do not take 2202e1fc5a into account. Also
take into account, that iio_channel_get() is not managed,
so you will have to free the channel, if your return an
error after it.
PATCH 3 introduces a new warning:
drivers/power/twl4030_charger.c:211:12: warning: ‘twl4030_is_battery_present’ defined but not used [-Wunused-function]
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-12-04 23:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 11:27 [PATCH v2 0/3] Fixes for twl4030 charger H. Nikolaus Schaller
2015-11-02 11:27 ` [PATCH v2 1/3] drivers:power:twl4030-charger: fix problem with EPROBE_DEFER H. Nikolaus Schaller
2015-11-02 11:27 ` [PATCH v2 2/3] drivers:power:twl4030-charger: don't return after allocating irq H. Nikolaus Schaller
2015-11-02 11:27 ` [PATCH v2 3/3] drivers:power:twl4030-charger: don't check if battery is present H. Nikolaus Schaller
2015-11-13 10:28 ` [PATCH v2 0/3] Fixes for twl4030 charger H. Nikolaus Schaller
2015-11-23 9:27 ` [Gta04-owner] " H. Nikolaus Schaller
2015-12-04 23:54 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204235442.GA22936@earth \
--to=sre@kernel.org \
--cc=andreas@kemnade.info \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gta04-owner@goldelico.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).