* [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
@ 2015-12-30 18:35 Andrew F. Davis
2015-12-31 18:40 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Andrew F. Davis @ 2015-12-30 18:35 UTC (permalink / raw)
To: Pali Rohár, Sebastian Reichel
Cc: linux-pm, linux-kernel, Andrew F. Davis
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
MAINTAINERS | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 44666b1..046d001 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
M: Pali Rohár <pali.rohar@gmail.com>
S: Maintained
F: include/linux/power/bq2415x_charger.h
-F: include/linux/power/bq27xxx_battery.h
F: include/linux/power/isp1704_charger.h
F: drivers/power/bq2415x_charger.c
-F: drivers/power/bq27xxx_battery.c
F: drivers/power/isp1704_charger.c
F: drivers/power/rx51_battery.c
@@ -10710,6 +10708,14 @@ L: linux-omap@vger.kernel.org
S: Maintained
F: drivers/thermal/ti-soc-thermal/
+TI BQ27XXX POWER SUPPLY DRIVER
+M: Pali Rohár <pali.rohar@gmail.com>
+R: Andrew F. Davis <afd@ti.com>
+S: Maintained
+F: include/linux/power/bq27xxx_battery.h
+F: drivers/power/bq27xxx_battery.c
+F: drivers/power/bq27xxx_battery_i2c.c
+
TI CDCE706 CLOCK DRIVER
M: Max Filippov <jcmvbkbc@gmail.com>
S: Maintained
--
2.6.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
2015-12-30 18:35 [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver Andrew F. Davis
@ 2015-12-31 18:40 ` Pali Rohár
2015-12-31 21:06 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2015-12-31 18:40 UTC (permalink / raw)
To: Andrew F. Davis; +Cc: Sebastian Reichel, linux-pm, linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 1362 bytes --]
On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> MAINTAINERS | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 44666b1..046d001 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> M: Pali Rohár <pali.rohar@gmail.com>
> S: Maintained
> F: include/linux/power/bq2415x_charger.h
> -F: include/linux/power/bq27xxx_battery.h
> F: include/linux/power/isp1704_charger.h
> F: drivers/power/bq2415x_charger.c
> -F: drivers/power/bq27xxx_battery.c
> F: drivers/power/isp1704_charger.c
> F: drivers/power/rx51_battery.c
>
I think it is not needed to remove files from this section as here are
all power supply files for Nokia N900.
> @@ -10710,6 +10708,14 @@ L: linux-omap@vger.kernel.org
> S: Maintained
> F: drivers/thermal/ti-soc-thermal/
>
> +TI BQ27XXX POWER SUPPLY DRIVER
> +M: Pali Rohár <pali.rohar@gmail.com>
> +R: Andrew F. Davis <afd@ti.com>
> +S: Maintained
> +F: include/linux/power/bq27xxx_battery.h
> +F: drivers/power/bq27xxx_battery.c
> +F: drivers/power/bq27xxx_battery_i2c.c
> +
> TI CDCE706 CLOCK DRIVER
> M: Max Filippov <jcmvbkbc@gmail.com>
> S: Maintained
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
2015-12-31 18:40 ` Pali Rohár
@ 2015-12-31 21:06 ` Sebastian Reichel
2015-12-31 21:11 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2015-12-31 21:06 UTC (permalink / raw)
To: Pali Rohár; +Cc: Andrew F. Davis, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3318 bytes --]
Hi,
On Thu, Dec 31, 2015 at 07:40:04PM +0100, Pali Rohár wrote:
> On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
> > ---
> > MAINTAINERS | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 44666b1..046d001 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> > M: Pali Rohár <pali.rohar@gmail.com>
> > S: Maintained
> > F: include/linux/power/bq2415x_charger.h
> > -F: include/linux/power/bq27xxx_battery.h
> > F: include/linux/power/isp1704_charger.h
> > F: drivers/power/bq2415x_charger.c
> > -F: drivers/power/bq27xxx_battery.c
> > F: drivers/power/isp1704_charger.c
> > F: drivers/power/rx51_battery.c
>
> I think it is not needed to remove files from this section as here are
> all power supply files for Nokia N900.
>
> > @@ -10710,6 +10708,14 @@ L: linux-omap@vger.kernel.org
> > S: Maintained
> > F: drivers/thermal/ti-soc-thermal/
> >
> > +TI BQ27XXX POWER SUPPLY DRIVER
> > +M: Pali Rohár <pali.rohar@gmail.com>
> > +R: Andrew F. Davis <afd@ti.com>
> > +S: Maintained
> > +F: include/linux/power/bq27xxx_battery.h
> > +F: drivers/power/bq27xxx_battery.c
> > +F: drivers/power/bq27xxx_battery_i2c.c
I think it would make sense to have it like this:
NOKIA N900 POWER SUPPLY DRIVERS
+R: Pali Rohár <pali.rohar@gmail.com>
-M: Pali Rohár <pali.rohar@gmail.com>
-S: Maintained
F: include/linux/power/bq2415x_charger.h
F: include/linux/power/bq27xxx_battery.h
F: include/linux/power/isp1704_charger.h
F: drivers/power/bq2415x_charger.c
F: drivers/power/bq27xxx_battery.c
F: drivers/power/isp1704_charger.c
F: drivers/power/rx51_battery.c
+TI BQ27XXX POWER SUPPLY DRIVER
+R: Andrew F. Davis <afd@ti.com>
+F: include/linux/power/bq27xxx_battery.h
+F: drivers/power/bq27xxx_battery.c
+F: drivers/power/bq27xxx_battery_i2c.c
+
POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M: Sebastian Reichel <sre@kernel.org>
M: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
M: David Woodhouse <dwmw2@infradead.org>
L: linux-pm@vger.kernel.org
T: git git://git.infradead.org/battery-2.6.git
S: Maintained
F: include/linux/power_supply.h
F: drivers/power/
X: drivers/power/avs/
This would result in the following get_maintainer.pl output
for the bq27xxx driver.
sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f drivers/power/bq27xxx_battery.c
"Andrew F. Davis" <afd@ti.com> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER)
"Pali Rohár" <pali.rohar@gmail.com> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
Sebastian Reichel <sre@kernel.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
David Woodhouse <dwmw2@infradead.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-pm@vger.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-kernel@vger.kernel.org (open list)
Pali, what do you think about the reviewer/maintainer change?
I think it makes it more clear, that the patches are queued in
the battery tree. If you think its a downgrade I don't mind not
changing it, though.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
2015-12-31 21:06 ` Sebastian Reichel
@ 2015-12-31 21:11 ` Pali Rohár
2016-01-15 14:24 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2015-12-31 21:11 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Andrew F. Davis, linux-pm, linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 3694 bytes --]
On Thursday 31 December 2015 22:06:38 Sebastian Reichel wrote:
> Hi,
>
> On Thu, Dec 31, 2015 at 07:40:04PM +0100, Pali Rohár wrote:
> > On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> > > Signed-off-by: Andrew F. Davis <afd@ti.com>
> > > ---
> > >
> > > MAINTAINERS | 10 ++++++++--
> > > 1 file changed, 8 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 44666b1..046d001 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> > >
> > > M: Pali Rohár <pali.rohar@gmail.com>
> > > S: Maintained
> > > F: include/linux/power/bq2415x_charger.h
> > >
> > > -F: include/linux/power/bq27xxx_battery.h
> > >
> > > F: include/linux/power/isp1704_charger.h
> > > F: drivers/power/bq2415x_charger.c
> > >
> > > -F: drivers/power/bq27xxx_battery.c
> > >
> > > F: drivers/power/isp1704_charger.c
> > > F: drivers/power/rx51_battery.c
> >
> > I think it is not needed to remove files from this section as here
> > are all power supply files for Nokia N900.
> >
> > > @@ -10710,6 +10708,14 @@ L: linux-omap@vger.kernel.org
> > >
> > > S: Maintained
> > > F: drivers/thermal/ti-soc-thermal/
> > >
> > > +TI BQ27XXX POWER SUPPLY DRIVER
> > > +M: Pali Rohár <pali.rohar@gmail.com>
> > > +R: Andrew F. Davis <afd@ti.com>
> > > +S: Maintained
> > > +F: include/linux/power/bq27xxx_battery.h
> > > +F: drivers/power/bq27xxx_battery.c
> > > +F: drivers/power/bq27xxx_battery_i2c.c
>
> I think it would make sense to have it like this:
>
> NOKIA N900 POWER SUPPLY DRIVERS
> +R: Pali Rohár <pali.rohar@gmail.com>
> -M: Pali Rohár <pali.rohar@gmail.com>
> -S: Maintained
> F: include/linux/power/bq2415x_charger.h
> F: include/linux/power/bq27xxx_battery.h
> F: include/linux/power/isp1704_charger.h
> F: drivers/power/bq2415x_charger.c
> F: drivers/power/bq27xxx_battery.c
> F: drivers/power/isp1704_charger.c
> F: drivers/power/rx51_battery.c
>
> +TI BQ27XXX POWER SUPPLY DRIVER
> +R: Andrew F. Davis <afd@ti.com>
> +F: include/linux/power/bq27xxx_battery.h
> +F: drivers/power/bq27xxx_battery.c
> +F: drivers/power/bq27xxx_battery_i2c.c
> +
> POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
> M: Sebastian Reichel <sre@kernel.org>
> M: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> M: David Woodhouse <dwmw2@infradead.org>
> L: linux-pm@vger.kernel.org
> T: git git://git.infradead.org/battery-2.6.git
> S: Maintained
> F: include/linux/power_supply.h
> F: drivers/power/
> X: drivers/power/avs/
>
> This would result in the following get_maintainer.pl output
> for the bq27xxx driver.
>
> sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f
> drivers/power/bq27xxx_battery.c "Andrew F. Davis" <afd@ti.com>
> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER) "Pali Rohár"
> <pali.rohar@gmail.com> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
> Sebastian Reichel <sre@kernel.org> (maintainer:POWER SUPPLY
> CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and
> DRIVERS) David Woodhouse <dwmw2@infradead.org> (maintainer:POWER
> SUPPLY CLASS/SUBSYSTEM and DRIVERS) linux-pm@vger.kernel.org (open
> list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> Pali, what do you think about the reviewer/maintainer change?
> I think it makes it more clear, that the patches are queued in
> the battery tree. If you think its a downgrade I don't mind not
> changing it, though.
>
> -- Sebastian
Change is OK for me.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
2015-12-31 21:11 ` Pali Rohár
@ 2016-01-15 14:24 ` Pali Rohár
0 siblings, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2016-01-15 14:24 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Andrew F. Davis, linux-pm, linux-kernel
On Thursday 31 December 2015 22:11:32 Pali Rohár wrote:
> On Thursday 31 December 2015 22:06:38 Sebastian Reichel wrote:
> > Hi,
> >
> > I think it would make sense to have it like this:
> >
> > NOKIA N900 POWER SUPPLY DRIVERS
> > +R: Pali Rohár <pali.rohar@gmail.com>
> > -M: Pali Rohár <pali.rohar@gmail.com>
> > -S: Maintained
> > F: include/linux/power/bq2415x_charger.h
> > F: include/linux/power/bq27xxx_battery.h
> > F: include/linux/power/isp1704_charger.h
> > F: drivers/power/bq2415x_charger.c
> > F: drivers/power/bq27xxx_battery.c
> > F: drivers/power/isp1704_charger.c
> > F: drivers/power/rx51_battery.c
> >
> > +TI BQ27XXX POWER SUPPLY DRIVER
> > +R: Andrew F. Davis <afd@ti.com>
> > +F: include/linux/power/bq27xxx_battery.h
> > +F: drivers/power/bq27xxx_battery.c
> > +F: drivers/power/bq27xxx_battery_i2c.c
> > +
> > POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
> > M: Sebastian Reichel <sre@kernel.org>
> > M: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> > M: David Woodhouse <dwmw2@infradead.org>
> > L: linux-pm@vger.kernel.org
> > T: git git://git.infradead.org/battery-2.6.git
> > S: Maintained
> > F: include/linux/power_supply.h
> > F: drivers/power/
> > X: drivers/power/avs/
> >
> > This would result in the following get_maintainer.pl output
> > for the bq27xxx driver.
> >
> > sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f
> > drivers/power/bq27xxx_battery.c "Andrew F. Davis" <afd@ti.com>
> > (reviewer:TI BQ27XXX POWER SUPPLY DRIVER) "Pali Rohár"
> > <pali.rohar@gmail.com> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
> > Sebastian Reichel <sre@kernel.org> (maintainer:POWER SUPPLY
> > CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov
> > <dbaryshkov@gmail.com> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and
> > DRIVERS) David Woodhouse <dwmw2@infradead.org> (maintainer:POWER
> > SUPPLY CLASS/SUBSYSTEM and DRIVERS) linux-pm@vger.kernel.org (open
> > list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> > linux-kernel@vger.kernel.org (open list)
> >
> > Pali, what do you think about the reviewer/maintainer change?
> > I think it makes it more clear, that the patches are queued in
> > the battery tree. If you think its a downgrade I don't mind not
> > changing it, though.
> >
> > -- Sebastian
>
> Change is OK for me.
>
Sebastian, one one minor change to your patch:
Add bq27xxx_battery_i2c.c file into NOKIA N900 POWER SUPPLY DRIVERS
section as now bq27200 code is split into two files...
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-15 14:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 18:35 [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver Andrew F. Davis
2015-12-31 18:40 ` Pali Rohár
2015-12-31 21:06 ` Sebastian Reichel
2015-12-31 21:11 ` Pali Rohár
2016-01-15 14:24 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).