linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] power, test_power: correctly handle empty writes
@ 2015-12-22 17:43 Sasha Levin
  2016-01-07 17:40 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2015-12-22 17:43 UTC (permalink / raw)
  To: sre, dbaryshkov, dwmw2
  Cc: linux-pm, linux-kernel, john.stultz, cbouatmailru, Sasha Levin

Writing 0 length data into test_power makes it access an invalid array
location and kill the system.

Fixes: f17ef9b2d ("power: Make test_power driver more dynamic.")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 drivers/power/test_power.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/power/test_power.c b/drivers/power/test_power.c
index 83c42ea..57246cd 100644
--- a/drivers/power/test_power.c
+++ b/drivers/power/test_power.c
@@ -301,6 +301,8 @@ static int map_get_value(struct battery_property_map *map, const char *key,
 	buf[MAX_KEYLENGTH-1] = '\0';
 
 	cr = strnlen(buf, MAX_KEYLENGTH) - 1;
+	if (cr < 0)
+		return def_val;
 	if (buf[cr] == '\n')
 		buf[cr] = '\0';
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-07 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 17:43 [PATCH] power, test_power: correctly handle empty writes Sasha Levin
2016-01-07 17:40 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).