On Friday 01 January 2016 12:26:21 Pali Rohár wrote: > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > > All calls to isp1704_write() are using parameter sequence of > > isp1704_write(isp, reg, val) but the function is defined as > > isp1704_write(isp, val, reg). Fix isp1704_write function definition > > so that the driver to be functional. > > > > Signed-off-by: Ivaylo Dimitrov > > Reviewed-by: Pali Rohár > > This problem is there since inclusion of driver itself. No idea why > that driver could work... I remember that it detected correctly type > of charger. > > I will test this patch on real N900 HW in one or two weeks to check > how it behave after patching... Tested-by: Pali Rohár Please send this patch to all stable kernels. -- Pali Rohár pali.rohar@gmail.com