From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
X86 Kernel <x86@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 1/2] x86/msr: add on cpu read/modify/write function
Date: Tue, 12 Jan 2016 17:14:26 -0800 [thread overview]
Message-ID: <20160112171426.20062fa8@yairi> (raw)
In-Reply-To: <alpine.DEB.2.11.1512201421300.28591@nanos>
On Sun, 20 Dec 2015 14:28:48 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> So this is a copy of the above !SMP inline. What's wrong with
> providing:
>
> int rmwmsrl_safe(msr_no, clear_mask, set_mask)
>
> in x86/lib/msr.c and make the !SMP variant of rdmsrl_safe_on_cpu()
> and that variant for the SMP case a simple wrapper around it?
>
> static void remote_rmwmsrl_safe(void *info)
> {
> struct msr_action *ma = info;
>
> return rmwmsrl_safe(ma->msr, ma->clear_mask, ma->set_mask);
> }
>
> No gotos, no pointless code duplication. Just simple.
much better, just sent new code in v2. Sorry for the delay.
Thanks
next prev parent reply other threads:[~2016-01-13 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 22:40 [PATCH 0/2] combine remote cpu msr access Jacob Pan
2015-12-11 22:40 ` [PATCH 1/2] x86/msr: add on cpu read/modify/write function Jacob Pan
2015-12-20 13:28 ` Thomas Gleixner
2015-12-20 15:27 ` Borislav Petkov
2016-01-13 1:14 ` Jacob Pan [this message]
2015-12-11 22:40 ` [PATCH 2/2] powercap/rapl: reduce ipi calls Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112171426.20062fa8@yairi \
--to=jacob.jun.pan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).