* [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address
@ 2016-01-09 14:10 Liu Xiang
2016-01-13 15:16 ` Andrew F. Davis
2016-01-15 2:13 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Liu Xiang @ 2016-01-09 14:10 UTC (permalink / raw)
To: linux-pm; +Cc: pali.rohar, sre, dbaryshkov, dwmw2, Liu Xiang
Currently in bq27541 driver, the average power register address is
incorrectly set to 0x76, which would result in an error:
bq27xxx-battery 2-0055: error reading average power register 10: -11
According to the bq27541 datasheet, fix this problem by setting
the average power register address to 0x24.
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
v4:
- Modify the patch format.
---
drivers/power/bq27xxx_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index 880233c..633f96d 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
INVALID_REG_ADDR, /* AE - NA */
0x2c, /* SOC(RSOC) */
0x3c, /* DCAP */
- 0x76, /* AP */
+ 0x24, /* AP */
};
static u8 bq27545_regs[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address
2016-01-09 14:10 [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address Liu Xiang
@ 2016-01-13 15:16 ` Andrew F. Davis
2016-01-15 2:13 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew F. Davis @ 2016-01-13 15:16 UTC (permalink / raw)
To: Liu Xiang, linux-pm; +Cc: pali.rohar, sre, dbaryshkov, dwmw2
On 01/09/2016 08:10 AM, Liu Xiang wrote:
> Currently in bq27541 driver, the average power register address is
> incorrectly set to 0x76, which would result in an error:
> bq27xxx-battery 2-0055: error reading average power register 10: -11
> According to the bq27541 datasheet, fix this problem by setting
> the average power register address to 0x24.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
> ---
> v4:
> - Modify the patch format.
> ---
> drivers/power/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 880233c..633f96d 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
> INVALID_REG_ADDR, /* AE - NA */
> 0x2c, /* SOC(RSOC) */
> 0x3c, /* DCAP */
> - 0x76, /* AP */
> + 0x24, /* AP */
> };
>
> static u8 bq27545_regs[] = {
>
Acked-by: Andrew F. Davis <afd@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address
2016-01-09 14:10 [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address Liu Xiang
2016-01-13 15:16 ` Andrew F. Davis
@ 2016-01-15 2:13 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2016-01-15 2:13 UTC (permalink / raw)
To: Liu Xiang; +Cc: linux-pm, pali.rohar, dbaryshkov, dwmw2
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
Hi,
On Sat, Jan 09, 2016 at 10:10:39PM +0800, Liu Xiang wrote:
> Currently in bq27541 driver, the average power register address is
> incorrectly set to 0x76, which would result in an error:
> bq27xxx-battery 2-0055: error reading average power register 10: -11
> According to the bq27541 datasheet, fix this problem by setting
> the average power register address to 0x24.
Thanks, queued and already pulled by Torvalds.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-15 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-09 14:10 [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address Liu Xiang
2016-01-13 15:16 ` Andrew F. Davis
2016-01-15 2:13 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).