* Re: [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
[not found] <1452885673-30891-9-git-send-email-anders.roxell@linaro.org>
@ 2016-01-18 17:02 ` Sebastian Andrzej Siewior
2016-01-20 21:28 ` Anders Roxell
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-01-18 17:02 UTC (permalink / raw)
To: Anders Roxell
Cc: linux-rt-users, khilman, ccross, Rafael J. Wysocki,
daniel.lezcano, linux-pm
* Anders Roxell | 2016-01-15 20:21:12 [+0100]:
>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>warning without this fix:
>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
>defined but not used [-Wunused-variable]
>
>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Could you please forward this patch upstream? The driver was introduced
in 4126c0197bc8 ("cpuidle: add support for states that affect multiple
cpus") with the cpuidle_coupled_lock variable unused. This is not -RT
specific.
>---
> drivers/cpuidle/coupled.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>index 344058f..d5657d5 100644
>--- a/drivers/cpuidle/coupled.c
>+++ b/drivers/cpuidle/coupled.c
>@@ -119,7 +119,6 @@ struct cpuidle_coupled {
>
> #define CPUIDLE_COUPLED_NOT_IDLE (-1)
>
>-static DEFINE_MUTEX(cpuidle_coupled_lock);
> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
>
> /*
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
2016-01-18 17:02 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Sebastian Andrzej Siewior
@ 2016-01-20 21:28 ` Anders Roxell
0 siblings, 0 replies; 2+ messages in thread
From: Anders Roxell @ 2016-01-20 21:28 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-rt-users, Kevin Hilman, ccross, Rafael J. Wysocki,
daniel.lezcano, linux-pm
On 18 January 2016 at 18:02, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> * Anders Roxell | 2016-01-15 20:21:12 [+0100]:
>
>>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>>warning without this fix:
>>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
>>defined but not used [-Wunused-variable]
>>
>>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Could you please forward this patch upstream? The driver was introduced
> in 4126c0197bc8 ("cpuidle: add support for states that affect multiple
> cpus") with the cpuidle_coupled_lock variable unused. This is not -RT
> specific.
Yes, I'll do that.
Cheers,
Anders
>
>>---
>> drivers/cpuidle/coupled.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>>index 344058f..d5657d5 100644
>>--- a/drivers/cpuidle/coupled.c
>>+++ b/drivers/cpuidle/coupled.c
>>@@ -119,7 +119,6 @@ struct cpuidle_coupled {
>>
>> #define CPUIDLE_COUPLED_NOT_IDLE (-1)
>>
>>-static DEFINE_MUTEX(cpuidle_coupled_lock);
>> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
>>
>> /*
>
> Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-20 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1452885673-30891-9-git-send-email-anders.roxell@linaro.org>
2016-01-18 17:02 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Sebastian Andrzej Siewior
2016-01-20 21:28 ` Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).