From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Crash introduced by commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally")
Date: Tue, 19 Jan 2016 11:55:12 -0800 [thread overview]
Message-ID: <20160119195512.GA17729@kroah.com> (raw)
In-Reply-To: <20160119190709.GA3338@pengutronix.de>
On Tue, Jan 19, 2016 at 08:07:09PM +0100, Uwe Kleine-König wrote:
> Hello Alan,
>
> On Tue, Jan 19, 2016 at 01:22:22PM -0500, Alan Stern wrote:
> >
> > Your commit causes my ASUS laptop to crash during early boot. The
> > problem occurs in platform_drv_probe(), affecting both the alarmtimer
> > and the asus_laptop platform drivers (I can't tell which is the
> > critical one).
> >
> > The old code would not call platform_drv_probe() at all, and probing
> > would always succeed immediately because these drivers have no probe
> > routine. But with the new code, platform_drv_probe() does run. The
> > call to of_clk_set_defaults() returns -ENODEV, as does the call to
> > dev_pm_domain_attach(). The call to drv->probe() gets skipped, of
> > course. The final return value is -ENODEV, and so probing fails. This
> > causes the kernel to crash: blank screen, NumLock LED blinking.
> >
> > The patch below fixes the problem, but I'm not sure that it's the best
> > solution. What is your advice?
> You want
>
> http://mid.gmane.org/1449132704-9952-1-git-send-email-martin.wilck@ts.fujitsu.com
>
> .
>
> Greg, I'd welcome this fix in mainline and 4.4.x.
Yes it's in my queue to get to after 4.5-rc1 -s out.
thanks,
greg k-h
next prev parent reply other threads:[~2016-01-19 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:22 Crash introduced by commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally") Alan Stern
2016-01-19 19:07 ` Uwe Kleine-König
2016-01-19 19:55 ` Greg Kroah-Hartman [this message]
2016-01-19 20:06 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119195512.GA17729@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).