From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list Date: Mon, 25 Jan 2016 15:20:29 +0530 Message-ID: <20160125095029.GE3183@vireshk> References: <1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:36273 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755959AbcAYJud (ORCPT ); Mon, 25 Jan 2016 04:50:33 -0500 Received: by mail-pf0-f181.google.com with SMTP id n128so79510257pfn.3 for ; Mon, 25 Jan 2016 01:50:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Gautham R. Shenoy" Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shilpasri G Bhat , Juri Lelli On 25-01-16, 15:16, Gautham R. Shenoy wrote: > Currently next_policy() explicitly checks if a policy is the last > policy in the cpufreq_policy_list. Use the standard list_is_last > primitive instead. > > Cc: Viresh Kumar > Signed-off-by: Gautham R. Shenoy > --- > drivers/cpufreq/cpufreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 78b1e2f..b3059a3 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -67,11 +67,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy, > { > lockdep_assert_held(&cpufreq_driver_lock); > do { > - policy = list_next_entry(policy, policy_list); > - > /* No more policies in the list */ > - if (&policy->policy_list == &cpufreq_policy_list) > + if (list_is_last(&policy->policy_list, &cpufreq_policy_list)) > return NULL; > + > + policy = list_next_entry(policy, policy_list); > } while (!suitable_policy(policy, active)); > > return policy; Acked-by: Viresh Kumar -- viresh