From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com
Subject: Re: [PATCH 17/17] cpufreq: dt: No need to allocate resources anymore
Date: Mon, 25 Jan 2016 16:03:16 +0530 [thread overview]
Message-ID: <20160125103316.GA9155@vireshk> (raw)
In-Reply-To: <20160112022022.GV22188@codeaurora.org>
On 11-01-16, 18:20, Stephen Boyd wrote:
> > @@ -241,9 +234,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> > }
> >
> > priv->cpu_dev = cpu_dev;
> > - priv->cpu_reg = cpu_reg;
> > policy->driver_data = priv;
> > -
> > policy->clk = cpu_clk;
>
> Maybe we can have an dev_pm_opp_get_rate() API and a
> cpufreq_generic_opp_get() so we can get rid of policy->clk usage
> in this driver?
I thought about this today and couldn't get to a sane solution.
If we implement dev_pm_opp_get_rate(), then it should return the
cached value of the currently programmed OPP. If the OPP isn't set
yet, it can call clk_get_rate() and return that instead. But it
doesn't make any sense to always call clk_get_rate() from
dev_pm_opp_get_rate(), as that doesn't match its name.
OTOH, cpufreq really really needs a clk_get_rate() to happen, there
can be cases where the clk is changed by some other entity, specially
during suspend/resume and there are special checks in cpufreq about
that.
We can surely add a patch later if we get answer to this, but for now,
I will keep this patch as is.
--
viresh
next prev parent reply other threads:[~2016-01-25 10:33 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 10:16 [PATCH 00/17] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar
2015-12-22 10:16 ` [PATCH 01/17] PM / OPP: get/put regulators from OPP core Viresh Kumar
2016-01-11 23:21 ` Stephen Boyd
2016-01-12 3:05 ` Viresh Kumar
2016-01-12 5:23 ` Viresh Kumar
2016-01-12 19:32 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 02/17] PM / OPP: Add APIs to set regulator-name Viresh Kumar
2016-01-12 1:18 ` Stephen Boyd
2016-01-12 4:43 ` Viresh Kumar
2015-12-22 10:16 ` [PATCH 03/17] PM / OPP: Disable OPPs that aren't supported by the regulator Viresh Kumar
2016-01-12 1:19 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 04/17] PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() Viresh Kumar
2016-01-12 1:25 ` Stephen Boyd
2016-01-12 5:10 ` Viresh Kumar
2016-01-12 19:45 ` Stephen Boyd
2016-01-13 5:34 ` Viresh Kumar
2016-01-18 7:23 ` Viresh Kumar
2016-01-21 0:20 ` Stephen Boyd
2016-01-21 2:32 ` Viresh Kumar
2016-01-21 2:43 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 05/17] PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-12 2:20 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 06/17] PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings Viresh Kumar
2016-01-12 1:29 ` Stephen Boyd
2016-01-12 5:14 ` Viresh Kumar
2016-01-13 0:36 ` Stephen Boyd
2016-01-13 5:35 ` Viresh Kumar
2016-01-15 1:54 ` Stephen Boyd
2016-01-15 1:54 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 07/17] PM / OPP: Manage device clk Viresh Kumar
2016-01-12 1:32 ` Stephen Boyd
2016-01-12 5:43 ` Viresh Kumar
2016-01-12 19:47 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 08/17] PM / OPP: Add dev_pm_opp_set_rate() Viresh Kumar
2016-01-12 1:40 ` Stephen Boyd
2016-01-12 6:58 ` Viresh Kumar
2016-01-13 0:49 ` Stephen Boyd
2016-01-13 5:51 ` Viresh Kumar
2015-12-22 10:16 ` [PATCH 10/17] cpufreq: dt: Rename 'need_update' to 'opp_v1' Viresh Kumar
2016-01-12 1:41 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 11/17] cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well Viresh Kumar
2016-01-12 1:41 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 12/17] cpufreq: dt: Pass regulator name to the OPP core for V1 bindings Viresh Kumar
2016-01-12 1:53 ` Stephen Boyd
2016-01-12 7:11 ` Viresh Kumar
2016-01-13 0:43 ` Stephen Boyd
2016-01-13 5:47 ` Viresh Kumar
2016-01-13 11:15 ` Mark Brown
2015-12-22 10:16 ` [PATCH 13/17] cpufreq: dt: Unsupported OPPs are already disabled Viresh Kumar
2016-01-12 1:53 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 14/17] cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-12 1:54 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 15/17] cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Viresh Kumar
2016-01-12 1:55 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 16/17] cpufreq: dt: drop references to DT node Viresh Kumar
2016-01-12 1:55 ` Stephen Boyd
2015-12-22 10:16 ` [PATCH 17/17] cpufreq: dt: No need to allocate resources anymore Viresh Kumar
2016-01-12 2:20 ` Stephen Boyd
2016-01-12 7:34 ` Viresh Kumar
2016-01-21 1:18 ` Stephen Boyd
2016-01-21 2:36 ` Viresh Kumar
2016-01-21 2:45 ` Stephen Boyd
2016-01-25 10:33 ` Viresh Kumar [this message]
2015-12-22 10:20 ` [PATCH 09/17] cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() Viresh Kumar
2016-01-12 1:40 ` Stephen Boyd
2015-12-23 3:12 ` [PATCH 00/17] PM / OPP: Introduce APIs to transition OPPs Rafael J. Wysocki
2015-12-23 2:46 ` Viresh Kumar
2016-01-11 16:28 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125103316.GA9155@vireshk \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).