From: Juri Lelli <juri.lelli@arm.com>
To: Gautham R Shenoy <ego@linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list
Date: Wed, 27 Jan 2016 10:10:20 +0000 [thread overview]
Message-ID: <20160127101020.GL10898@e106622-lin> (raw)
In-Reply-To: <20160127060923.GB28238@in.ibm.com>
On 27/01/16 11:39, Gautham R Shenoy wrote:
> On Mon, Jan 25, 2016 at 11:18:24AM +0000, Juri Lelli wrote:
> > Hi,
> >
> > On 25/01/16 15:20, Viresh Kumar wrote:
> > > On 25-01-16, 15:16, Gautham R. Shenoy wrote:
> > > > Currently next_policy() explicitly checks if a policy is the last
> > > > policy in the cpufreq_policy_list. Use the standard list_is_last
> > > > primitive instead.
> > > >
> > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> > > > ---
> > > > drivers/cpufreq/cpufreq.c | 6 +++---
> > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > > index 78b1e2f..b3059a3 100644
> > > > --- a/drivers/cpufreq/cpufreq.c
> > > > +++ b/drivers/cpufreq/cpufreq.c
> > > > @@ -67,11 +67,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy,
> > > > {
> > > > lockdep_assert_held(&cpufreq_driver_lock);
> >
> > Which branch is this patch based on?
>
> My bad! This is based on your branch git://linux-arm.org/linux-jl.git
> upstream/cpufreq_cleanups. I found this issue while reviewing your
> cleanup patches.
>
No problem, and thanks for reviewing those! Any feedback? :)
Best,
- Juri
next prev parent reply other threads:[~2016-01-27 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 9:46 [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list Gautham R. Shenoy
2016-01-25 9:50 ` Viresh Kumar
2016-01-25 11:18 ` Juri Lelli
2016-01-25 11:22 ` Viresh Kumar
2016-01-27 5:57 ` Gautham R Shenoy
2016-01-27 6:09 ` Gautham R Shenoy
2016-01-27 10:10 ` Juri Lelli [this message]
2016-01-27 11:12 ` Gautham R Shenoy
2016-01-27 6:32 ` [PATCH RESEND] " Gautham R. Shenoy
2016-01-27 6:36 ` Viresh Kumar
2016-01-27 22:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127101020.GL10898@e106622-lin \
--to=juri.lelli@arm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).