From: Pavel Machek <pavel@ucw.cz>
To: Abhilash Jindal <klock.android@gmail.com>
Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net
Subject: Re: [PATCH] PM/freezer: y2038, use boottime to compare tstamps
Date: Sun, 31 Jan 2016 20:42:55 +0100 [thread overview]
Message-ID: <20160131194255.GA31180@amd> (raw)
In-Reply-To: <1454268541-28064-1-git-send-email-klock.android@gmail.com>
On Sun 2016-01-31 14:29:01, Abhilash Jindal wrote:
> Wall time obtained from do_gettimeofday gives 32 bit timeval which can only
> represent time until January 2038. This patch moves to ktime_t, a 64-bit time.
>
> Also, wall time is susceptible to sudden jumps due to user setting the time or
> due to NTP. Boot time is constantly increasing time better suited for
> subtracting two timestamps.
Umm. Setting time while we are freezeing is probably not going to be a
problem, but ok, why not... Code is simpler as well, and 2038 is
coming ;-).
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-01-31 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 19:29 [PATCH] PM/freezer: y2038, use boottime to compare tstamps Abhilash Jindal
2016-01-31 19:42 ` Pavel Machek [this message]
2016-02-21 13:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131194255.GA31180@amd \
--to=pavel@ucw.cz \
--cc=klock.android@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).