From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core Date: Tue, 2 Feb 2016 08:53:47 +0530 Message-ID: <20160202032347.GA31828@vireshk> References: <69e87438205ee12c7e884f9a3114b2f695e8b59a.1453965717.git.viresh.kumar@linaro.org> <20160202022921.GI4848@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:35963 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbcBBDXv (ORCPT ); Mon, 1 Feb 2016 22:23:51 -0500 Received: by mail-pa0-f52.google.com with SMTP id yy13so92925267pab.3 for ; Mon, 01 Feb 2016 19:23:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160202022921.GI4848@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Stephen Boyd Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek , Viresh Kumar On 01-02-16, 18:29, Stephen Boyd wrote: > I'm still lost why we need this API. When the OPP is torn down we > can call regulator_put there instead. The same style seems to be > done for supported hw, and prop_name, which doesn't make any > sense either. Just tear everything down when there aren't any > more OPPs in the table. I explained that earlier as well, but you never replied to that :) Let me paste that again here: Consider this case: - Platform code sets regulator for cpuX (Create OPP-table struct and set regulator) - insmod cpufreq-dt.ko (Fill OPP table) - rmmod cpufreq-dt.ko (Remove OPP table and struct, according to your suggestion) - insmod cpufreq-dt.ko (No regulator found). The platform code is supposed to set regulator, supported-hw, prop-name only once from some init-code. And it should just work out of the box after that. And so these calls are really required. -- viresh