From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 2/5] cpufreq: governor: Create separate sysfs-ops Date: Wed, 3 Feb 2016 16:25:13 +0530 Message-ID: <20160203105513.GA3469@vireshk> References: <20160202154717.GI3947@e106622-lin> <20160202170144.GL3947@e106622-lin> <56B12BEC.9070603@codeaurora.org> <56B158A0.6060604@codeaurora.org> <20160203065442.GV31828@vireshk> <20160203105107.GQ3947@e106622-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:34152 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbcBCKzQ (ORCPT ); Wed, 3 Feb 2016 05:55:16 -0500 Received: by mail-pa0-f53.google.com with SMTP id uo6so12031948pac.1 for ; Wed, 03 Feb 2016 02:55:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160203105107.GQ3947@e106622-lin> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Juri Lelli Cc: Saravana Kannan , "Rafael J. Wysocki" , Rafael Wysocki , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Peter Zijlstra , Michael Turquette , Steve Muckle , Vincent Guittot , Morten Rasmussen , dietmar.eggemann@arm.com, Linux Kernel Mailing List On 03-02-16, 10:51, Juri Lelli wrote: > I also think that sched-dvfs should not use cpufreq_governor.c. It is > useful boilerplate code for ondemand and conservative, as they share lot > of data structures and how they work, but it doesn't necessarily suit > everybody's needs, IMHO. > > OTOH, fixing the current issue in the best way we can come up with has > still value of course :). Right. cpufreq_governor.c is more about the technique where we do load evaluation using deferred timers and workqueues, which isn't required for sched-dvfs. We can just move the common parts, like, governor_show/governor_store routines, and the new macros being added here. -- viresh