From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core
Date: Mon, 8 Feb 2016 14:55:15 -0800 [thread overview]
Message-ID: <20160208225515.GF10791@codeaurora.org> (raw)
In-Reply-To: <20160202061013.GC31828@vireshk>
On 02/02, Viresh Kumar wrote:
> static int allocate_resources(int cpu, struct device **cdev,
> struct regulator **creg, struct clk **cclk)
> {
> @@ -200,6 +225,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> unsigned long min_uV = ~0, max_uV = 0;
> unsigned int transition_latency;
> bool opp_v1 = false;
> + const char *name = NULL;
Is this initialization necessary?
> int ret;
>
> ret = allocate_resources(policy->cpu, &cpu_dev, &cpu_reg, &cpu_clk);
> @@ -229,6 +255,25 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> }
>
> /*
> + * OPP layer will be taking care of regulators now, but it needs to know
> + * the name of the regulator first.
> + */
> + name = find_supply_name(cpu_dev, np);
> + if (IS_ERR(name)) {
This looks to never happen?
> + ret = PTR_ERR(name);
> + goto out_node_put;
> + }
> +
> + if (name) {
> + ret = dev_pm_opp_set_regulator(cpu_dev, name);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-08 22:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:20 [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core Viresh Kumar
2016-02-02 2:29 ` Stephen Boyd
2016-02-02 3:23 ` Viresh Kumar
2016-02-08 22:52 ` Stephen Boyd
2016-02-09 3:53 ` Viresh Kumar
2016-02-09 3:54 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 03/16] PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() Viresh Kumar
2016-02-02 2:30 ` Stephen Boyd
2016-01-28 8:20 ` [PATCH V2 04/16] PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 05/16] PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 06/16] PM / OPP: Manage device clk Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 07/16] PM / OPP: Add dev_pm_opp_set_rate() Viresh Kumar
2016-02-02 2:10 ` Stephen Boyd
2016-02-02 3:38 ` Viresh Kumar
2016-02-02 20:46 ` Stephen Boyd
2016-01-28 8:20 ` [PATCH V2 08/16] cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 09/16] cpufreq: dt: Rename 'need_update' to 'opp_v1' Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 10/16] cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core Viresh Kumar
2016-02-02 2:34 ` Stephen Boyd
2016-02-02 6:10 ` Viresh Kumar
2016-02-08 22:55 ` Stephen Boyd [this message]
2016-02-09 4:10 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 12/16] cpufreq: dt: Unsupported OPPs are already disabled Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 13/16] cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 14/16] cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 15/16] cpufreq: dt: drop references to DT node Viresh Kumar
2016-02-02 6:11 ` Viresh Kumar
2016-02-08 22:56 ` Stephen Boyd
2016-02-09 4:22 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 16/16] cpufreq: dt: No need to allocate resources anymore Viresh Kumar
2016-02-02 6:12 ` Viresh Kumar
2016-02-08 22:58 ` Stephen Boyd
2016-01-30 1:48 ` [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Stephen Boyd
2016-02-01 4:08 ` Viresh Kumar
2016-02-01 19:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208225515.GF10791@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).