From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Juri Lelli <juri.lelli@arm.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 5/7] cpufreq: governor: No need to manage state machine now
Date: Wed, 10 Feb 2016 11:06:37 +0530 [thread overview]
Message-ID: <20160210053637.GP22111@vireshk> (raw)
In-Reply-To: <CAJZ5v0gHk5L9vJ+BTnXdHAMzFZr7GX2RAD4gjSs+6L=NG3a0FQ@mail.gmail.com>
On 10-02-16, 01:36, Rafael J. Wysocki wrote:
> > static int cpufreq_governor_stop(struct cpufreq_policy *policy)
> > {
> > - struct policy_dbs_info *policy_dbs = policy->governor_data;
> > -
> > - /* State should be equivalent to START */
> > - if (!policy_dbs->policy)
> > - return -EBUSY;
> > -
> > - gov_cancel_work(policy_dbs);
> > - policy_dbs->policy = NULL;
> > + gov_cancel_work(policy);
> >
> > return 0;
> > }
>
> So maybe we can call gov_cancel_work(policy) from
> cpufreq_governor_dbs() directly and get rid of this wrapper too?
I thought about it, but left it for consistency. It wouldn't hurt, the
compiler will anyway make it inline I believe.
--
viresh
next prev parent reply other threads:[~2016-02-10 5:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 3:46 [PATCH V4 0/7] cpufreq: Locking fixes and cleanups Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 1/7] cpufreq: Merge cpufreq_offline_prepare/finish routines Viresh Kumar
2016-02-11 0:59 ` Rafael J. Wysocki
2016-02-11 1:15 ` Rafael J. Wysocki
2016-02-11 11:46 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held Viresh Kumar
2016-02-11 9:48 ` Rafael J. Wysocki
2016-02-11 11:52 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 3/7] cpufreq: Remove cpufreq_governor_lock Viresh Kumar
2016-02-11 9:53 ` Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 4/7] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c Viresh Kumar
2016-02-10 0:26 ` Rafael J. Wysocki
2016-02-10 7:00 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Viresh Kumar
2016-02-10 7:00 ` [PATCH V5 2/3] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-10 7:00 ` [PATCH V5 3/3] cpufreq: ondemand: Rearrange od_dbs_timer() to avoid updating delay Viresh Kumar
2016-02-11 9:58 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 5/7] " Viresh Kumar
2016-02-10 0:36 ` Rafael J. Wysocki
2016-02-10 5:36 ` Viresh Kumar [this message]
2016-02-09 3:46 ` [PATCH V4 6/7] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 7/7] cpufreq: ondemand: Rearrange od_dbs_timer() to void updating delay Viresh Kumar
2016-02-10 0:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210053637.GP22111@vireshk \
--to=viresh.kumar@linaro.org \
--cc=juri.lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).