From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Juri Lelli <juri.lelli@arm.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held
Date: Thu, 11 Feb 2016 17:22:54 +0530 [thread overview]
Message-ID: <20160211115254.GC28558@vireshk> (raw)
In-Reply-To: <CAJZ5v0hVhVyDvk1Vj5NAh1w1nXEZ6eF0v9x+8CfZ6pyKSu=k9g@mail.gmail.com>
On 11-02-16, 10:48, Rafael J. Wysocki wrote:
> On Tue, Feb 9, 2016 at 4:46 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Also note that cpufreq_driver->stop_cpu() and ->exit() can get called
> > while policy->rwsem is held. That shouldn't have any side effects
> > though.
>
> The last paragraph is unclear.
>
> Is it supposed to mean that the change will cause
> cpufreq_driver->stop_cpu() and ->exit() to be called under
> policy->rwsem sometimes?
Yeah, reworded it a bit ..
Also note that, after this patch cpufreq_driver->stop_cpu() and ->exit()
will get called while policy->rwsem is held, which wasn't the case
earlier. That shouldn't have any side effects though.
--
viresh
next prev parent reply other threads:[~2016-02-11 11:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 3:46 [PATCH V4 0/7] cpufreq: Locking fixes and cleanups Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 1/7] cpufreq: Merge cpufreq_offline_prepare/finish routines Viresh Kumar
2016-02-11 0:59 ` Rafael J. Wysocki
2016-02-11 1:15 ` Rafael J. Wysocki
2016-02-11 11:46 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held Viresh Kumar
2016-02-11 9:48 ` Rafael J. Wysocki
2016-02-11 11:52 ` Viresh Kumar [this message]
2016-02-09 3:46 ` [PATCH V4 3/7] cpufreq: Remove cpufreq_governor_lock Viresh Kumar
2016-02-11 9:53 ` Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 4/7] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c Viresh Kumar
2016-02-10 0:26 ` Rafael J. Wysocki
2016-02-10 7:00 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Viresh Kumar
2016-02-10 7:00 ` [PATCH V5 2/3] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-10 7:00 ` [PATCH V5 3/3] cpufreq: ondemand: Rearrange od_dbs_timer() to avoid updating delay Viresh Kumar
2016-02-11 9:58 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 5/7] " Viresh Kumar
2016-02-10 0:36 ` Rafael J. Wysocki
2016-02-10 5:36 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 6/7] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 7/7] cpufreq: ondemand: Rearrange od_dbs_timer() to void updating delay Viresh Kumar
2016-02-10 0:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211115254.GC28558@vireshk \
--to=viresh.kumar@linaro.org \
--cc=juri.lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).