From: Eduardo Valentin <edubezval@gmail.com>
To: Javi Merino <javi.merino@arm.com>
Cc: akpm@linux-foundation.org, rui.zhang@intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
drinkcat@chromium.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>
Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle
Date: Thu, 11 Feb 2016 07:00:28 -0800 [thread overview]
Message-ID: <20160211150027.GA24955@localhost.localdomain> (raw)
In-Reply-To: <1455192051-6430-1-git-send-email-javi.merino@arm.com>
On Thu, Feb 11, 2016 at 12:00:51PM +0000, Javi Merino wrote:
> In __cpufreq_cooling_register() we allocate the arrays for time_in_idle
> and time_in_idle_timestamp to be as big as the number of cpus in this
> cpufreq device. However, in get_load() we access this array using the
> cpu number as index, which can result in an out of bound access.
>
> Index time_in_idle{,_timestamp} using the index in the cpufreq_device's
> allowed_cpus mask, as we do for the load_cpu array in
> cpufreq_get_requested_power()
>
> Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> Cc: Amit Daniel Kachhap <amit.kachhap@gmail.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Javi Merino <javi.merino@arm.com>
> ---
> Hi Andrew,
>
> This patch fixes an out of bounds access found by Nicolas Boichat
> using KASAN. It is acked by Viresh, comaintainer of the cpu cooling
> device and tested by the reporter. It's been in the list[0] for more
> than a month, I've pinged the thermal maintainers three times but they
> haven't replied.
>
> Can you merge it via your tree? Thanks,
> Javi
Somehow this patch was marked as accepted in patchwork and I missed it,
apologize for this. I am adding it to thermal-soc.
BR,
Eduardo
next prev parent reply other threads:[~2016-02-11 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 12:00 [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle Javi Merino
2016-02-11 15:00 ` Eduardo Valentin [this message]
2016-02-11 18:45 ` Javi Merino
-- strict thread matches above, loose matches on Subject: below --
2015-12-19 12:54 Javi Merino
2015-12-21 3:19 ` Viresh Kumar
2016-01-05 19:19 ` Javi Merino
2016-01-15 15:20 ` Javi Merino
2016-01-18 2:25 ` Nicolas Boichat
2016-01-25 14:44 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211150027.GA24955@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kachhap@gmail.com \
--cc=drinkcat@chromium.org \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).