From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Avoid unnecessary locking in show() and store()
Date: Fri, 12 Feb 2016 21:28:29 +0530 [thread overview]
Message-ID: <20160212155829.GA32705@vireshk-i7> (raw)
In-Reply-To: <16931364.qnKxgPucoY@vostro.rjw.lan>
On 12-02-16, 14:18, Rafael J. Wysocki wrote:
> Well, having a check that never fails is certainly unuseful.
>
> > So, even we may want to add a WARN_ON() for that case instead.
>
> I can add WARN_ON()s just fine.
What about dropping the check completely ?
--
viresh
next prev parent reply other threads:[~2016-02-12 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 1:25 [PATCH] cpufreq: Avoid unnecessary locking in show() and store() Rafael J. Wysocki
2016-02-12 6:31 ` Viresh Kumar
2016-02-12 13:18 ` Rafael J. Wysocki
2016-02-12 15:58 ` Viresh Kumar [this message]
2016-02-12 16:10 ` Rafael J. Wysocki
2016-02-12 16:20 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212155829.GA32705@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox