From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-pm@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: tvp5150 regression after commit 9f924169c035
Date: Fri, 12 Feb 2016 14:40:19 -0800 [thread overview]
Message-ID: <20160212224018.GZ3500@atomide.com> (raw)
In-Reply-To: <56BE5C97.9070607@osg.samsung.com>
* Javier Martinez Canillas <javier@osg.samsung.com> [160212 14:29]:
> On 02/12/2016 07:13 PM, Tony Lindgren wrote:
> >Hmm yeah I wonder if this canned solution helps here too:
> >
> >1. Check if the driver(s) are using pm_runtime_use_autosuspend()
> >
>
> By driver do you mean the OMAP GPIO driver or the tvp5150 I2C driver?
> The latter does not have runtime PM support.
Sounds like OMAP GPIO then.
> >2. If so, you must use pm_runtime_dont_use_autosuspend() before
> > pm_runtime_put_sync() to make sure that pm_runtime_put_sync()
> > works.
> >
> >3. Or you can use pm_runtime_put_sync_suspend() instead of
> > pm_runtime_put_sync() for sections of code where the clocks
> > need to be stopped.
> >
>
> I can check if the OMAP GPIO is following these and give a try but
> don't have access to the board right now so I'll do it on Monday.
It does not seem to be using pm_runtime_autosuspend(). Did you
try reverting commit de85b9d57ab ("PM / runtime: Re-init runtime
PM states at probe error and driver unbind") and see if that
helps?
If it does, then sounds like we may have some other regression
as well.
Regards,
Tony
next prev parent reply other threads:[~2016-02-12 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56B204CB.60602@osg.samsung.com>
2016-02-08 10:54 ` tvp5150 regression after commit 9f924169c035 Wolfram Sang
2016-02-12 22:09 ` Javier Martinez Canillas
2016-02-12 22:13 ` Tony Lindgren
2016-02-12 22:28 ` Javier Martinez Canillas
2016-02-12 22:40 ` Tony Lindgren [this message]
2016-02-12 23:08 ` Javier Martinez Canillas
2016-02-12 23:46 ` Tony Lindgren
2016-02-13 2:47 ` Javier Martinez Canillas
2016-04-12 22:32 ` Wolfram Sang
2016-04-13 22:39 ` Javier Martinez Canillas
2016-04-14 11:12 ` Wolfram Sang
2016-04-14 13:41 ` Javier Martinez Canillas
2016-04-14 14:19 ` Wolfram Sang
2016-04-14 14:27 ` Javier Martinez Canillas
2016-04-14 15:12 ` Tony Lindgren
2016-04-14 23:59 ` Javier Martinez Canillas
2016-04-15 14:58 ` Tony Lindgren
2016-04-15 16:48 ` Javier Martinez Canillas
2016-04-15 17:08 ` Tony Lindgren
2016-02-12 22:22 ` Wolfram Sang
2016-02-12 22:26 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212224018.GZ3500@atomide.com \
--to=tony@atomide.com \
--cc=javier@osg.samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).