linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly
Date: Wed, 17 Feb 2016 10:42:18 +0530	[thread overview]
Message-ID: <20160217051218.GI2454@vireshk-i7> (raw)
In-Reply-To: <4864381.Sc603abrG6@vostro.rjw.lan>

On 16-02-16, 21:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Drop some lines of code from od_update() by arranging the statements
> in there in a more logical way.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_ondemand.c |   11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -175,14 +175,11 @@ static void od_update(struct cpufreq_pol
>  		/* No longer fully busy, reset rate_mult */
>  		policy_dbs->rate_mult = 1;
>  
> -		if (!od_tuners->powersave_bias) {
> -			__cpufreq_driver_target(policy, freq_next,
> -					CPUFREQ_RELATION_C);
> -			return;
> -		}
> +		if (od_tuners->powersave_bias)
> +			freq_next = od_ops.powersave_bias_target(policy,
> +								 freq_next,
> +								 CPUFREQ_RELATION_L);
>  
> -		freq_next = od_ops.powersave_bias_target(policy, freq_next,
> -					CPUFREQ_RELATION_L);
>  		__cpufreq_driver_target(policy, freq_next, CPUFREQ_RELATION_C);
>  	}
>  }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

  reply	other threads:[~2016-02-17  5:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 19:59 [PATCH 0/2] cpufreq: ondemand: Small cleanups Rafael J. Wysocki
2016-02-16 20:00 ` [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly Rafael J. Wysocki
2016-02-17  5:12   ` Viresh Kumar [this message]
2016-02-16 20:01 ` [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops Rafael J. Wysocki
2016-02-17  5:14   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217051218.GI2454@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).