From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops
Date: Wed, 17 Feb 2016 10:44:01 +0530 [thread overview]
Message-ID: <20160217051401.GJ2454@vireshk-i7> (raw)
In-Reply-To: <2785243.lPbWKikLZB@vostro.rjw.lan>
On 16-02-16, 21:01, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The ->freq_increase callback in struct od_ops is never invoked,
> so drop it.
>
> No functional changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq_governor.h | 1 -
> drivers/cpufreq/cpufreq_ondemand.c | 1 -
> 2 files changed, 2 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -417,7 +417,6 @@ define_get_cpu_dbs_routines(od_cpu_dbs_i
> static struct od_ops od_ops = {
> .powersave_bias_init_cpu = ondemand_powersave_bias_init_cpu,
> .powersave_bias_target = generic_powersave_bias_target,
> - .freq_increase = dbs_freq_increase,
> };
>
> static struct dbs_governor od_dbs_gov = {
> Index: linux-pm/drivers/cpufreq/cpufreq_governor.h
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h
> +++ linux-pm/drivers/cpufreq/cpufreq_governor.h
> @@ -220,7 +220,6 @@ struct od_ops {
> void (*powersave_bias_init_cpu)(int cpu);
> unsigned int (*powersave_bias_target)(struct cpufreq_policy *policy,
> unsigned int freq_next, unsigned int relation);
> - void (*freq_increase)(struct cpufreq_policy *policy, unsigned int freq);
> };
>
> extern struct mutex dbs_data_mutex;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2016-02-17 5:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 19:59 [PATCH 0/2] cpufreq: ondemand: Small cleanups Rafael J. Wysocki
2016-02-16 20:00 ` [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly Rafael J. Wysocki
2016-02-17 5:12 ` Viresh Kumar
2016-02-16 20:01 ` [PATCH 2/2] cpufreq: ondemand: Drop unused callback from struct od_ops Rafael J. Wysocki
2016-02-17 5:14 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217051401.GJ2454@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).