From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 8/12] cpufreq: governor: Make governor private data per-policy Date: Thu, 18 Feb 2016 11:33:24 +0530 Message-ID: <20160218060324.GN2610@vireshk-i7> References: <2938006.67J0esUvOA@vostro.rjw.lan> <1954429.fugFc6iA7T@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:35517 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756729AbcBRGDh (ORCPT ); Thu, 18 Feb 2016 01:03:37 -0500 Received: by mail-pa0-f42.google.com with SMTP id ho8so25475615pac.2 for ; Wed, 17 Feb 2016 22:03:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <1954429.fugFc6iA7T@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List On 18-02-16, 02:30, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Some fields in struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s > are only used for a limited set of CPUs. Namely, if a policy is > shared between multiple CPUs, those fields will only be used for one > of them (policy->cpu). This means that they really are per-policy > rather than per-CPU and holding room for them in per-CPU data > structures is generally wasteful. Also moving those fields into > per-policy data structures will allow some significant simplifications > to be made going forward. > > For this reason, introduce struct cs_policy_dbs_info and > struct od_policy_dbs_info to hold those fields. Define each of the > new structures as an extension of struct policy_dbs_info (such that > struct policy_dbs_info is embedded in each of them) and introduce > new ->alloc and ->free governor callbacks to allocate and free > those structures, respectively, such that ->alloc() will return > a pointer to the struct policy_dbs_info embedded in the allocated > data structure and ->free() will take that pointer as its argument. > > With that, modify the code accessing the data fields in question > in per-CPU data objects to look for them in the new structures > via the struct policy_dbs_info pointer available to it and drop > them from struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s. Fantastic, that's what I just suggested in the previous patch :) Acked-by: Viresh Kumar -- viresh