From: Leo Yan <leo.yan@linaro.org>
To: Javi Merino <javi.merino@arm.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Punit Agrawal <punit.agrawal@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: use %d to print S32 parameters
Date: Thu, 18 Feb 2016 17:42:22 +0800 [thread overview]
Message-ID: <20160218094222.GB28887@leoy-linaro> (raw)
In-Reply-To: <20160113092216.GB2594@e104805>
On Wed, Jan 13, 2016 at 09:22:16AM +0000, Javi Merino wrote:
> On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:
> > Power allocator's parameters are S32 type, so use %d to print them.
>
> Indeed. The name of the macro is create_s32_tzp_attr(), it's
> explicitly saying that the parameter is signed!
>
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> Acked-by: Javi Merino <javi.merino@arm.com>
Rui, Eduardo,
Could you help merge this patch as well?
Thanks,
Leo Yan
>
> Cheers,
> Javi
>
> > ---
> > drivers/thermal/thermal_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index d9e525c..1335df2 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
> > struct thermal_zone_device *tz = to_thermal_zone(dev); \
> > \
> > if (tz->tzp) \
> > - return sprintf(buf, "%u\n", tz->tzp->name); \
> > + return sprintf(buf, "%d\n", tz->tzp->name); \
> > else \
> > return -EIO; \
> > } \
> > --
> > 1.9.1
> >
prev parent reply other threads:[~2016-02-18 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 8:33 [PATCH] thermal: use %d to print S32 parameters Leo Yan
2016-01-13 9:22 ` Javi Merino
2016-02-18 9:42 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218094222.GB28887@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).