From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] cpufreq: qoriq depends on thermal Date: Fri, 26 Feb 2016 20:50:15 +0530 Message-ID: <20160226152015.GA21797@vireshk-i7> References: <1456489361-469413-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:35696 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcBZPUR (ORCPT ); Fri, 26 Feb 2016 10:20:17 -0500 Received: by mail-pa0-f50.google.com with SMTP id ho8so54020713pac.2 for ; Fri, 26 Feb 2016 07:20:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <1456489361-469413-1-git-send-email-arnd@arndb.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Arnd Bergmann Cc: "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, Jia Hongtao , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 26-02-16, 13:22, Arnd Bergmann wrote: > The thermal subsystem can be a loadable module, so the qoriq driver has to be > a module in that case as well in order to call of_cpufreq_cooling_register: > > drivers/built-in.o: In function `qoriq_cpufreq_ready': > text+0x1f4548): undefined reference to `of_cpufreq_cooling_register' > > This adds a dependency that clarifies how we can either build the driver > when the cpu_thermal support is completely disabled, or how it depends > on the thermal support to enforce the qoriq driver to be a module. > > Signed-off-by: Arnd Bergmann > Fixes: 8ae1702a0df5 ("cpufreq: qoriq: Register cooling device based on device tree") > --- > drivers/cpufreq/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > My patch is from Dec 22, and I had marked it as submitted, but can't > find the email now, so maybe I forgot to send it out back then. > > The problem still exists in linux-next, please apply the patch > for 4.6. > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index dcb972a38fbc..ca05037dd565 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -297,6 +297,7 @@ endif > config QORIQ_CPUFREQ > tristate "CPU frequency scaling driver for Freescale QorIQ SoCs" > depends on OF && COMMON_CLK && (PPC_E500MC || ARM) > + depends on !CPU_THERMAL || THERMAL=y > select CLK_QORIQ > help > This adds the CPUFreq driver support for Freescale QorIQ SoCs Acked-by: Viresh Kumar -- viresh