From: Viresh Kumar <viresh.kumar@linaro.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: cpufreq: Additional interface for acpi-cpufreq
Date: Tue, 1 Mar 2016 08:09:42 +0530 [thread overview]
Message-ID: <20160301023942.GC16437@vireshk-i7> (raw)
In-Reply-To: <1456791009-950-3-git-send-email-srinivas.pandruvada@linux.intel.com>
On 29-02-16, 16:10, Srinivas Pandruvada wrote:
> Added new file for acpi-cpufreq driver, with explanation for
> base_frequency.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> Documentation/cpu-freq/acpi-cpufreq-addition.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/cpu-freq/acpi-cpufreq-addition.txt
>
> diff --git a/Documentation/cpu-freq/acpi-cpufreq-addition.txt b/Documentation/cpu-freq/acpi-cpufreq-addition.txt
s/-addition//
> new file mode 100644
> index 0000000..40efb22
> --- /dev/null
> +++ b/Documentation/cpu-freq/acpi-cpufreq-addition.txt
> @@ -0,0 +1,20 @@
> +Additional sysfs attribute for acpi-cpufreq
You should be adding a description of freqdomain_cpus in this file, which was
never documented (yes, in a separate patch).
> +In addition to the standard sysfs interface as defined in the
> +user-guide.txt under section "Preferred Interface: sysfs",
> +acpi-cpufreq can have following additional sysfs attribute:
Maybe rewrite as:
acpi-cpufreq have following sysfs attributes in addition to standard cpufreq
attributes:
> +
> +base_frequency: Max non-turbo frequency
> +For example:
Please keep the formatting similar to user-guide.txt
> +scaling_available_frequencies displays list of available frequencies
> which can be used to set max/min or current scaling frequency.
Just drop above line.
> +>cat scaling_available_frequencies
> +2301000 2300000 2200000 2000000 1900000 1800000 1700000 1500000 1400000
> +1300000 1100000 1000000 900000 800000 600000 500000
A blank line here.. This is documentation and should be really readable.
> +If the base_frequency attribute is present,
*is present* isn't sufficient, right? It should be readable as well?
> then any frequency above is
s/above/above base_frequency/
> +purely opportunistic or turbo frequency. For example
s/purely opportunistic or / a/
> +>cat base_frequency
> +2200000
Blank line here as well:
> +Then in the above displayed list of scaling_available_frequencies, any
> +frequency 2300000 or 2301000 is opportunistic or turbo frequency.
Maybe just:
i.e. 2300000 and 2301000 are turbo frequencies now..
> +
> --
> 2.5.0
--
viresh
next prev parent reply other threads:[~2016-03-01 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 0:10 [PATCH 0/2] acpi-cpufreq: introduce base_frequency Srinivas Pandruvada
2016-03-01 0:10 ` [PATCH 1/2] cpufreq: acpi_cpufreq: base frequency attribute support Srinivas Pandruvada
2016-03-01 0:10 ` [PATCH 2/2] Documentation: cpufreq: Additional interface for acpi-cpufreq Srinivas Pandruvada
2016-03-01 2:39 ` Viresh Kumar [this message]
2016-03-01 2:33 ` [PATCH 0/2] acpi-cpufreq: introduce base_frequency Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301023942.GC16437@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).