From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros Date: Tue, 1 Mar 2016 13:20:06 -0500 Message-ID: <20160301132006.1cda539c@gandalf.local.home> References: <1456853934-24715-1-git-send-email-michele.digiorgio@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456853934-24715-1-git-send-email-michele.digiorgio@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Michele Di Giorgio Cc: linux-pm@vger.kernel.org, Ingo Molnar , Javi Merino , linux-kernel@vger.kernel.org, Punit Agrawal , Eduardo Valentin List-Id: linux-pm@vger.kernel.org On Tue, 1 Mar 2016 17:38:54 +0000 Michele Di Giorgio wrote: > Userspace tools are not aware of how to convert the enums provided by > the tracepoints to their corresponding strings. > > Adding TRACE_DEFINE_ENUM() macros allows to make the enums available > to userspace to let the tools know what those enum values represent. > > In particular, for thermal zone trip types what we obtained before was > something like: > > kworker/1:1-460 [001] 320.372732: thermal_zone_trip: thermal_zone=soc > id=0 trip=1 trip_type=1 > > Unfortunately, userspace tools do not know how to convert enum values to > strings and as a consequence they can only forward the enum value to the > output. By using TRACE_DEFINE_ENUM() macros for thermal traces we get the > following trace line: > > kworker/1:1-460 [001] 320.372732: thermal_zone_trip: thermal_zone=soc > id=0 trip=1 trip_type=PASSIVE > > Userspace tools are now able to better understand the meaning of the trip_type > and provide the user with more readable information. > Acked-by: Steven Rostedt -- Steve