From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] PM: Fix crash on graph trace through x86 suspend Date: Wed, 2 Mar 2016 21:07:50 -0500 Message-ID: <20160302210750.147efd34@grimm.local.home> References: <1456963529-4962-1-git-send-email-todd.e.brandt@linux.intel.com> <1456965812.5488.4.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Todd Brandt , "linux-pm@vger.kernel.org" , Rafael Wysocki , todd.e.brandt@intel.com, Linux Kernel Mailing List , x86@kernel.org, ACPI Devel Maling List List-Id: linux-pm@vger.kernel.org On Thu, 3 Mar 2016 02:36:26 +0100 "Rafael J. Wysocki" wrote: > > OK, applied, but let Steven and the x86 folks see it. The below patch looks fine to me. Anything else I should look at? -- Steve > > > >>> > >>> > --- > >>> > arch/x86/kernel/acpi/sleep.c | 7 +++++++ > >>> > 1 file changed, 7 insertions(+) > >>> > > >>> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c > >>> > index d1daead..311360e 100644 > >>> > --- a/arch/x86/kernel/acpi/sleep.c > >>> > +++ b/arch/x86/kernel/acpi/sleep.c > >>> > @@ -16,6 +16,7 @@ > >>> > #include > >>> > #include > >>> > > >>> > +#include > >>> > #include "../../realmode/rm/wakeup.h" > >>> > #include "sleep.h" > >>> > > >>> > @@ -107,7 +108,13 @@ int x86_acpi_suspend_lowlevel(void) > >>> > saved_magic = 0x123456789abcdef0L; > >>> > #endif /* CONFIG_64BIT */ > >>> > > >>> > + /* > >>> > + * Pause/unpause graph tracing around do_suspend_lowlevel as it has > >>> > + * inconsistent call/return info after it jumps to the wakeup vector > >>> > + */ > >>> > + pause_graph_tracing(); > >>> > do_suspend_lowlevel(); > >>> > + unpause_graph_tracing(); > >>> > return 0; > >>> > } > >>> > > >>> > -- > >>> > 2.1.4 > >>> > > >>> > -- > > > > > > Thanks, > > Rafael