linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Philippe Loctaux <phil@philippeloctaux.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kernel: Power: main.c: Cleaned up a comment block
Date: Tue, 8 Mar 2016 10:44:53 +0100	[thread overview]
Message-ID: <20160308094452.GA14693@amd> (raw)
In-Reply-To: <1457345355-20102-1-git-send-email-phil@philippeloctaux.com>

On Mon 2016-03-07 11:09:15, Philippe Loctaux wrote:
> Removed a * in the beginning of the block, and removed an unnecessary space.
> 
> Signed-off-by: Philippe Loctaux <phil@philippeloctaux.com>

NAK.

Google kerneldoc, people actually like two spaces after ., and you
should not be changing whitespace unless you update code, anyway.
								Pavel

> ---
>  kernel/power/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 2794697..d7386cb 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -288,11 +288,11 @@ static inline void pm_print_times_init(void) {}
>  
>  struct kobject *power_kobj;
>  
> -/**
> +/*
>   * state - control system sleep states.
>   *
>   * show() returns available sleep state labels, which may be "mem", "standby",
> - * "freeze" and "disk" (hibernation).  See Documentation/power/states.txt for a
> + * "freeze" and "disk" (hibernation). See Documentation/power/states.txt for a
>   * description of what they mean.
>   *
>   * store() accepts one of those strings, translates it into the proper

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2016-03-08  9:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 10:09 [PATCH] Kernel: Power: main.c: Cleaned up a comment block Philippe Loctaux
2016-03-08  9:44 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308094452.GA14693@amd \
    --to=pavel@ucw.cz \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=phil@philippeloctaux.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).