From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding Date: Tue, 8 Mar 2016 13:07:45 -0800 Message-ID: <20160308210744.GA8145@localhost.localdomain> References: <1455819551-4666-1-git-send-email-javier@osg.samsung.com> <1455819551-4666-2-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1455819551-4666-2-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Pawel Moll , Zhang Rui , Mark Rutland List-Id: linux-pm@vger.kernel.org On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote: > The Exynos Thermal Management Unit binding says that the vtmu-supply > is optional but is listed in the required properties section. Add an > optional properties section and move the regulator property there. > > Signed-off-by: Javier Martinez Canillas > --- > > Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > index faa62059b5c5..70b4c16c7ed8 100644 > --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt > @@ -41,9 +41,6 @@ > for current TMU channel > -- "tmu_sclk" clock for functional operation of the current TMU > channel > -- vtmu-supply: This entry is optional and provides the regulator node supplying > - voltage to TMU. If needed this entry can be placed inside > - board/platform specific dts file. > > The Exynos TMU supports generating interrupts when reaching given > temperature thresholds. Number of supported thermal trip points depends Where is this patch based on? I checked it on my fixes and linus branches, also on linux-next 0308 branch, and none of those apply clean. Can you please send this based on upstream kernel? > @@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC): > - samsung,tmu_default_temp_offset: Default temperature offset > - samsung,tmu_cal_type: Callibration type > > +** Optional properties: > + > +- vtmu-supply: This entry is optional and provides the regulator node supplying > + voltage to TMU. If needed this entry can be placed inside > + board/platform specific dts file. > + > Example 1): > > tmu@100C0000 { > -- > 2.5.0 >