From: Eduardo Valentin <edubezval@gmail.com>
To: Wei Ni <wni@nvidia.com>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] thermal: consistently use int for trip temp
Date: Tue, 8 Mar 2016 13:09:02 -0800 [thread overview]
Message-ID: <20160308210900.GB8145@localhost.localdomain> (raw)
In-Reply-To: <56DE45F7.6060307@nvidia.com>
On Tue, Mar 08, 2016 at 11:24:39AM +0800, Wei Ni wrote:
>
>
> On 2016年03月07日 16:23, Wei Ni wrote:
> > There had a build error in previous patch.
> > Fixed it in this version.
> > Please review it.
>
> Add CC: linux-pm@vger.kernel.org
>
> >
> > Thanks.
> > Wei.
> >
> > On 2016年03月03日 17:33, Wei Ni wrote:
> >> The commit 17e8351a7739 consistently use int for temperature,
> >> however it missed a few in trip temperature and thermal_core.
> >>
> >> In current codes, the trip->temperature used "unsigned long"
> >> and zone->temperature used"int", if the temperature is negative
> >> value, it will get wrong result when compare temperature with
> >> trip temperature.
> >>
> >> This patch can fix it.
> >>
> >> Signed-off-by: Wei Ni <wni@nvidia.com>
Rui are you collecting this one?
Acked-by: Eduardo Valentin <edubezval@gmail.com>
next prev parent reply other threads:[~2016-03-08 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1456997626-28298-1-git-send-email-wni@nvidia.com>
[not found] ` <56DD3A84.4080304@nvidia.com>
2016-03-08 3:24 ` [PATCH v2] thermal: consistently use int for trip temp Wei Ni
2016-03-08 21:09 ` Eduardo Valentin [this message]
2016-03-14 9:44 ` Wei Ni
2016-04-12 8:51 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308210900.GB8145@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).