From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering utilization update callbacks Date: Wed, 9 Mar 2016 14:32:47 +0100 Message-ID: <20160309133247.GA14756@gmail.com> References: <3071836.JbNxX8hU6x@vostro.rjw.lan> <2044559.7ypXocW9OZ@vostro.rjw.lan> <3499355.2JlaSruvOa@vostro.rjw.lan> <16016177.YFqb4gVNBo@vostro.rjw.lan> <20160309123539.GL6356@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33865 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbcCINcv (ORCPT ); Wed, 9 Mar 2016 08:32:51 -0500 Content-Disposition: inline In-Reply-To: <20160309123539.GL6356@twins.programming.kicks-ass.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Linux PM list , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Juri Lelli , Steve Muckle , Thomas Gleixner * Peter Zijlstra wrote: > On Mon, Feb 15, 2016 at 10:47:22PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Introduce a mechanism by which parts of the cpufreq subsystem > > ("setpolicy" drivers or the core) can register callbacks to be > > executed from cpufreq_update_util() which is invoked by the > > scheduler's update_load_avg() on CPU utilization changes. > > > > This allows the "setpolicy" drivers to dispense with their timers > > and do all of the computations they need and frequency/voltage > > adjustments in the update_load_avg() code path, among other things. > > > > The update_load_avg() changes were suggested by Peter Zijlstra. > > > > Signed-off-by: Rafael J. Wysocki > > Acked-by: Viresh Kumar > > --- > > drivers/cpufreq/cpufreq.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/cpufreq.h | 34 ++++++++++++++++++++++++++++++++++ > > kernel/sched/deadline.c | 4 ++++ > > kernel/sched/fair.c | 26 +++++++++++++++++++++++++- > > kernel/sched/rt.c | 4 ++++ > > kernel/sched/sched.h | 1 + > > 6 files changed, 113 insertions(+), 1 deletion(-) > > > > So with the understanding that we'll work on getting rid of > cpufreq_trigger_update(). > > Acked-by: Peter Zijlstra (Intel) I'm happy with the latest iteration and with the general direction as well! Acked-by: Ingo Molnar Thanks, Ingo