From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH 11/13] thermal: convert exynos to use devm_thermal_zone_of_sensor_register Date: Thu, 10 Mar 2016 10:16:13 +0100 Message-ID: <20160310101613.2d00b5e2@amdc2363> References: <1457559336-17652-1-git-send-email-edubezval@gmail.com> <1457559336-17652-12-git-send-email-edubezval@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:51939 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934335AbcCJJQ2 (ORCPT ); Thu, 10 Mar 2016 04:16:28 -0500 In-reply-to: <1457559336-17652-12-git-send-email-edubezval@gmail.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Eduardo Valentin Cc: Rui Zhang , Linux PM , LKML , lm-sensors@lm-sensors.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Eduardo, > This changes the driver to use the devm_ version > of thermal_zone_of_sensor_register and cleans > up the local points and unregister calls. > > Cc: Lukasz Majewski > Cc: Zhang Rui > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-pm@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > drivers/thermal/samsung/exynos_tmu.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c index fa61eff..256039e 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1363,8 +1363,8 @@ static int exynos_tmu_probe(struct > platform_device *pdev) > * data->tzd must be registered before calling > exynos_tmu_initialize(), > * requesting irq and calling exynos_tmu_control(). > */ > - data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, > data, > - > &exynos_sensor_ops); > + data->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, > 0, data, > + > &exynos_sensor_ops); if (IS_ERR(data->tzd)) { > ret = PTR_ERR(data->tzd); > dev_err(&pdev->dev, "Failed to register sensor: > %d\n", ret); @@ -1374,21 +1374,19 @@ static int > exynos_tmu_probe(struct platform_device *pdev) ret = > exynos_tmu_initialize(pdev); if (ret) { > dev_err(&pdev->dev, "Failed to initialize TMU\n"); > - goto err_thermal; > + goto err_sclk; > } > > ret = devm_request_irq(&pdev->dev, data->irq, exynos_tmu_irq, > IRQF_TRIGGER_RISING | IRQF_SHARED, > dev_name(&pdev->dev), data); if (ret) { > dev_err(&pdev->dev, "Failed to request irq: %d\n", > data->irq); > - goto err_thermal; > + goto err_sclk; > } > > exynos_tmu_control(pdev, true); > return 0; > > -err_thermal: > - thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd); > err_sclk: > clk_disable_unprepare(data->sclk); > err_clk: > @@ -1406,9 +1404,7 @@ err_sensor: > static int exynos_tmu_remove(struct platform_device *pdev) > { > struct exynos_tmu_data *data = platform_get_drvdata(pdev); > - struct thermal_zone_device *tzd = data->tzd; > > - thermal_zone_of_sensor_unregister(&pdev->dev, tzd); > exynos_tmu_control(pdev, false); > > clk_disable_unprepare(data->sclk); Reviewed-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group